From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EFD5AA09E8; Tue, 8 Dec 2020 16:32:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9EA94C90A; Tue, 8 Dec 2020 16:32:49 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id 48860C90A for ; Tue, 8 Dec 2020 16:32:48 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id A6AFDA42; Tue, 8 Dec 2020 10:32:43 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 08 Dec 2020 10:32:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= QlB9deki0S2sRFC5Wg0zjnCebhay6cCSgHMlWHR8qtw=; b=Np03jBizIu0ZKAw6 KcVKg0mfML5+3nigCLjR3uB3etQKQfUcSLTBjL7Udk40P0a/29aqX2gD3Q7fwRNG kThZkaGqg8Aj0ubXDUEmzZk07A6F/WBqAcmb+PSl+aNaIf1GqCsGrjdwO9ogtyE0 MEs9C7TmO+93MhhEGWHKh93KGcAS1rY0lWlcOB4ts9SDHejLdMEIG86snVZm7GCM IGFyfdaI9KxvGG+t3SO1/o0ukfixEcNLKlxKLZq98cMJQx8NG+QtZbazw2o+wpCG 9XpBdImOGC3kXb07XfsagYw9pz1iYiH+4OKzCIFQcmSu4a3Q7PhV9i/dogrxL2ZI TUkF3A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=QlB9deki0S2sRFC5Wg0zjnCebhay6cCSgHMlWHR8q tw=; b=nWaubrk+6oVeUP2phknXTSPFN6FEYAVKCQWWlmqPMCOiuXkO+cnGcb8x/ SvXs+ktakFSQYT2/anDou596OsaamoAhdmV6WtSjVR8/AFMWK2Ng+8te3ytARBpm O4MT0hw95/f2FR4rboqyYJ8wQGHmpv9cxo/m7mx4+ijSutTiwge5tR3FVbA9Eq5M yjaUe4eHPgVHlvCHmeYuoAQKVYKjjHCwTPA8s8/+K9hb6ydVRKAew9INWiHkLx9B d4qdNypPrPVn6xDKxWrqkLfAegz/2ZnUgptqlJTJkkhb9hv5zsg9ihUzGJKhTnQ1 lxZcFfobzYA/ojO+euQiZqMV2CyWg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudejiedgjeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 76D2E108005F; Tue, 8 Dec 2020 10:32:41 -0500 (EST) From: Thomas Monjalon To: dev@dpdk.org, "Kinsella, Ray" Cc: david.marchand@redhat.com, bruce.richardson@intel.com, Neil Horman Date: Tue, 08 Dec 2020 16:32:40 +0100 Message-ID: <1689676.9eEyGTFzmW@thomas> In-Reply-To: <477b7775-0a3e-080b-3158-bc8fbae95c81@ashroe.eu> References: <20201207173235.1397351-1-thomas@monjalon.net> <477b7775-0a3e-080b-3158-bc8fbae95c81@ashroe.eu> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/1] devtools: adjust verbosity of ABI check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/12/2020 16:22, Kinsella, Ray: > > On 07/12/2020 17:32, Thomas Monjalon wrote: > > The scripts gen-abi.sh and check-abi.sh are updated > > to print error messages to stderr so they are likely never ignored. > > > > When called from test-meson-builds.sh, the standard messages on stdout > > can be more quiet depending on the verbosity settings. > > The beginning of the ABI check is announced in verbose mode. > > The commands are printed in very verbose mode. > > The check result details are available in verbose mode. > > So there is a bit of a disconnect here - you change gen-abi/check-abi to > correctly direct errors to sterr. > > You then however provide a method to ignore them in test_meson_build.sh. > I thinking giving people a way of ignoring the indicated lines below, > is a bad plan. > > No problem with the changes to check-abi/gen-abi - but I think the changes > to test_meson_build.sh are a bad idea. No the errors are not ignored. Only stdout (report details) is redirected. > > $srcdir/devtools/check-abi.sh $abirefdir/$targetdir \ > > - $(readlink -f $builds_dir/$targetdir/install) > > + $(readlink -f $builds_dir/$targetdir/install) >&$verbose