From: longli@linuxonhyperv.com
To: Ferruh Yigit <ferruh.yigit@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: dev@dpdk.org, Ajay Sharma <sharmaajay@microsoft.com>,
Long Li <longli@microsoft.com>
Subject: [PATCH] net/mana: use %m for fscanf to read mac address
Date: Tue, 25 Jul 2023 14:16:55 -0700 [thread overview]
Message-ID: <1690319815-28594-2-git-send-email-longli@linuxonhyperv.com> (raw)
In-Reply-To: <1690319815-28594-1-git-send-email-longli@linuxonhyperv.com>
From: Long Li <longli@microsoft.com>
Use %m through fscanf to allocate mac dynamically is safer than using
mac[20], this guarantees there is no overflow on mac[].
Signed-off-by: Long Li <longli@microsoft.com>
---
drivers/net/mana/mana.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana.c
index f1fdcf426a..28d8f5b23e 100644
--- a/drivers/net/mana/mana.c
+++ b/drivers/net/mana/mana.c
@@ -914,7 +914,6 @@ get_port_mac(struct ibv_device *device, unsigned int port,
DIR *dir;
struct dirent *dent;
unsigned int dev_port;
- char mac[20];
MANA_MKSTR(path, "%s/device/net", device->ibdev_path);
@@ -924,6 +923,7 @@ get_port_mac(struct ibv_device *device, unsigned int port,
while ((dent = readdir(dir))) {
char *name = dent->d_name;
+ char *mac = NULL;
MANA_MKSTR(port_path, "%s/%s/dev_port", path, name);
@@ -951,7 +951,7 @@ get_port_mac(struct ibv_device *device, unsigned int port,
if (!file)
continue;
- ret = fscanf(file, "%s", mac);
+ ret = fscanf(file, "%ms", &mac);
fclose(file);
if (ret < 0)
@@ -960,6 +960,8 @@ get_port_mac(struct ibv_device *device, unsigned int port,
ret = rte_ether_unformat_addr(mac, addr);
if (ret)
DRV_LOG(ERR, "unrecognized mac addr %s", mac);
+
+ free(mac);
break;
}
}
--
2.34.1
next prev parent reply other threads:[~2023-07-25 21:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 21:16 [PATCH] net/mana: add support to update MTU longli
2023-07-25 21:16 ` longli [this message]
2023-09-28 18:46 ` [PATCH] net/mana: use %m for fscanf to read mac address Ferruh Yigit
2023-09-28 19:14 ` [PATCH] net/mana: add support to update MTU Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1690319815-28594-2-git-send-email-longli@linuxonhyperv.com \
--to=longli@linuxonhyperv.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=longli@microsoft.com \
--cc=sharmaajay@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).