DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] examples/l3fwd: fix compilation issue when using exact-match
Date: Mon, 10 Aug 2015 22:39:08 +0200	[thread overview]
Message-ID: <1690471.oTkHzXzv9N@xps13> (raw)
In-Reply-To: <3011799.hGDSXbeMWp@xps13>

2015-08-10 19:13, Thomas Monjalon:
> 2015-08-10 18:58, Thomas Monjalon:
> > Hi Pablo,
> > 
> > 2015-08-09 11:28, Pablo de Lara:
> > > From: "Pablo de Lara" <pablo.de.lara.guarch@intel.com>
> > > 
> > > L3fwd was trying to use an inexistent function "simple_ipv6_fwd_4pkts",
> > > instead it should be "simple_ipv6_fwd_8pkts", and "simple_ipv8_fwd_4pkts"
> > > instead of "simple_ipv4_fwd_8pkts".
> > > 
> > > Fixes: 80fcb4d4 ("examples/l3fwd: increase lookup burst size to 8")
> > > 
> > > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > > Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
> > > ---
> > > 
> > > Changes in v2:
> > > 
> > > - Missing to fix additional type
> > 
> > More fixes are needed:
> > 
> > make RTE_SDK=$(readlink -m ../..) RTE_TARGET=x86_64-native-linuxapp-clang \
> > 	EXTRA_CFLAGS='-DAPP_LOOKUP_METHOD=APP_LOOKUP_EXACT_MATCH'
> > 
> > examples/l3fwd/main.c:545:1: error: unused function 'send_packetsx4'
> > examples/l3fwd/main.c:1165:1: error: unused function 'rfc1812_process'
> > 
> > The right fix would be to remove one APP_LOOKUP_METHOD.
> 
> Build flags are:
> - APP_LOOKUP_METHOD
> - DO_RFC_1812_CHECKS
> - defined(__SSE4_1__) -> ENABLE_MULTI_BUFFER_OPTIMIZE
> - RTE_NEXT_ABI
> 
> Waiting a cleanup for 2.2, this fix should be OK and will be applied:

Applied with additional fix.

      reply	other threads:[~2015-08-10 20:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-07  9:08 [dpdk-dev] [PATCH] " Pablo de Lara
2015-08-07 10:07 ` Gonzalez Monroy, Sergio
2015-08-09  9:54 ` Thomas Monjalon
2015-08-09 10:28   ` De Lara Guarch, Pablo
2015-08-09 10:28 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2015-08-10 16:58   ` Thomas Monjalon
2015-08-10 17:13     ` Thomas Monjalon
2015-08-10 20:39       ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1690471.oTkHzXzv9N@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=pablo.de.lara.guarch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).