DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] scripts: show full headline with checkpatch
@ 2016-11-05 15:28 Thomas Monjalon
  2016-11-06  9:35 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Monjalon @ 2016-11-05 15:28 UTC (permalink / raw)
  To: dev

The Subject in an email can be split on two lines.
In such case, the second line (starting with a space) can be
joined to the first one.

It is handled differently when parsing stdin or a file.

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 scripts/checkpatches.sh | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/scripts/checkpatches.sh b/scripts/checkpatches.sh
index 619ac21..2f67d24 100755
--- a/scripts/checkpatches.sh
+++ b/scripts/checkpatches.sh
@@ -101,13 +101,16 @@ check () { # <patch> <commit> <title>
 
 if [ -n "$1" ] ; then
 	for patch in "$@" ; do
-		subject=$(sed -n 's,^Subject: ,,p' "$patch")
+		# Subject can be on 2 lines
+		subject=$(sed '/^Subject: */!d;s///;N;s,\n[[:space:]]\+, ,;s,\n.*,,;q' "$patch")
 		check "$patch" '' "$subject"
 	done
 elif [ ! -t 0 ] ; then # stdin
 	subject=$(while read header value ; do
 		if [ "$header" = 'Subject:' ] ; then
-			echo $value
+			IFS= read next
+			continuation=$(echo "$next" | sed -n 's,^[[:space:]]\+, ,p')
+			echo $value$continuation
 			break
 		fi
 	done)
-- 
2.7.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] scripts: show full headline with checkpatch
  2016-11-05 15:28 [dpdk-dev] [PATCH] scripts: show full headline with checkpatch Thomas Monjalon
@ 2016-11-06  9:35 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2016-11-06  9:35 UTC (permalink / raw)
  To: dev

2016-11-05 16:28, Thomas Monjalon:
> The Subject in an email can be split on two lines.
> In such case, the second line (starting with a space) can be
> joined to the first one.
> 
> It is handled differently when parsing stdin or a file.
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-11-06  9:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-05 15:28 [dpdk-dev] [PATCH] scripts: show full headline with checkpatch Thomas Monjalon
2016-11-06  9:35 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).