DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Wiles, Keith" <keith.wiles@intel.com>
To: Pascal Mazon <pascal.mazon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v5 0/4] net/tap: support flow API
Date: Tue, 21 Mar 2017 15:48:44 +0000	[thread overview]
Message-ID: <1691FC7F-5C13-4F54-A5D1-CC30C7FE01FB@intel.com> (raw)
In-Reply-To: <cover.1489589508.git.pascal.mazon@6wind.com>


> On Mar 15, 2017, at 9:54 AM, Pascal Mazon <pascal.mazon@6wind.com> wrote:
> 
> This series add support for the flow API in tap PMD.
> 
> It enables filtering specific packets incoming on the tap netdevice, to
> process only desired ones. Under the hood, it uses kernel TC (traffic
> control), which takes place very early in the stack, and supports most
> common pattern items and actions defined in the flow API.
> 
> This series applies on top of:
> 
>  [PATCH 0/6] net/tap: add additional management ops
> 
> v2 changes:
>  - support compilation on kernels < 4.2 (where flower support appeared)
>  - set whitespaces in tap.h
>  - remove unnecessary goto
> 
> v3 changes:
>  - vlan patterns enabled depending on running kernel (4.9+)
>  - update doc/guides/nics/tap.rst for Flow API support
>  - rebase on top of "net/tap: add additional management ops" series
> 
> v4 changes:
>  - rebase on top of "net/tap: add additional management ops" series
>  - fix a few netlink doxygen comments
>  - rename tap.h -> rte_eth_tap.h
>  - flush flow rules only when applicable
> 
> v5 changes:
>  - rebase after adrien's patches on Tx poll and Rx signaling
>  - better spaces for comments in rte_eth_tap.h
> 
> Pascal Mazon (4):
>  net/tap: move private elements to external header
>  net/tap: add preliminary support for rte_flow
>  net/tap: add netlink back-end for flow API
>  net/tap: add basic flow API patterns and actions
> 
> doc/guides/nics/features/tap.ini |    1 +
> doc/guides/nics/tap.rst          |   23 +
> drivers/net/tap/Makefile         |   44 ++
> drivers/net/tap/rte_eth_tap.c    |  101 ++--
> drivers/net/tap/rte_eth_tap.h    |   80 +++
> drivers/net/tap/tap_flow.c       | 1078 ++++++++++++++++++++++++++++++++++++++
> drivers/net/tap/tap_flow.h       |   58 ++
> drivers/net/tap/tap_netlink.c    |  367 +++++++++++++
> drivers/net/tap/tap_netlink.h    |   69 +++
> drivers/net/tap/tap_tcmsgs.c     |  378 +++++++++++++
> drivers/net/tap/tap_tcmsgs.h     |   63 +++
> 11 files changed, 2227 insertions(+), 35 deletions(-)
> create mode 100644 drivers/net/tap/rte_eth_tap.h
> create mode 100644 drivers/net/tap/tap_flow.c
> create mode 100644 drivers/net/tap/tap_flow.h
> create mode 100644 drivers/net/tap/tap_netlink.c
> create mode 100644 drivers/net/tap/tap_netlink.h
> create mode 100644 drivers/net/tap/tap_tcmsgs.c
> create mode 100644 drivers/net/tap/tap_tcmsgs.h
> 
> -- 
> 2.8.0.rc0
> 

Going to Ack the series, but I am not an expert on flows. The only thing I saw was the missing C++ ifdefs in the headers, if that is required, then you can send that update in a new patch instead of reissuing this one, unless you want.

Acked-by: Keith.Wiles <keith.wiles@intel.com> for the series.

Regards,
Keith

  parent reply	other threads:[~2017-03-21 15:48 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-03 10:45 [dpdk-dev] [PATCH " Pascal Mazon
2017-03-03 10:45 ` [dpdk-dev] [PATCH 1/4] net/tap: move private elements to external header Pascal Mazon
2017-03-03 15:38   ` Wiles, Keith
2017-03-06 14:18     ` Pascal Mazon
2017-03-06 14:51       ` Wiles, Keith
2017-03-03 10:45 ` [dpdk-dev] [PATCH 2/4] net/tap: add preliminary support for rte_flow Pascal Mazon
2017-03-03 10:45 ` [dpdk-dev] [PATCH 3/4] net/tap: add netlink back-end for flow API Pascal Mazon
2017-03-03 10:45 ` [dpdk-dev] [PATCH 4/4] net/tap: add basic flow API patterns and actions Pascal Mazon
2017-03-03 15:47   ` Wiles, Keith
2017-03-06 14:22     ` Pascal Mazon
2017-03-03 15:54 ` [dpdk-dev] [PATCH 0/4] net/tap: support flow API Wiles, Keith
2017-03-06 17:05 ` [dpdk-dev] [PATCH v2 " Pascal Mazon
2017-03-06 17:05   ` [dpdk-dev] [PATCH v2 1/4] net/tap: move private elements to external header Pascal Mazon
2017-03-06 17:05   ` [dpdk-dev] [PATCH v2 2/4] net/tap: add preliminary support for rte_flow Pascal Mazon
2017-03-06 17:05   ` [dpdk-dev] [PATCH v2 3/4] net/tap: add netlink back-end for flow API Pascal Mazon
2017-03-06 17:05   ` [dpdk-dev] [PATCH v2 4/4] net/tap: add basic flow API patterns and actions Pascal Mazon
2017-03-07 15:05   ` [dpdk-dev] [PATCH v2 0/4] net/tap: support flow API Pascal Mazon
2017-03-07 15:08     ` Wiles, Keith
2017-03-07 16:35   ` [dpdk-dev] [PATCH v3 " Pascal Mazon
2017-03-07 16:35     ` [dpdk-dev] [PATCH v3 1/4] net/tap: move private elements to external header Pascal Mazon
2017-03-09 15:28       ` Ferruh Yigit
2017-03-10  9:40         ` Pascal Mazon
2017-03-07 16:35     ` [dpdk-dev] [PATCH v3 2/4] net/tap: add preliminary support for rte_flow Pascal Mazon
2017-03-07 16:35     ` [dpdk-dev] [PATCH v3 3/4] net/tap: add netlink back-end for flow API Pascal Mazon
2017-03-09 15:29       ` Ferruh Yigit
2017-03-10  9:39         ` Pascal Mazon
2017-03-07 16:35     ` [dpdk-dev] [PATCH v3 4/4] net/tap: add basic flow API patterns and actions Pascal Mazon
2017-03-14  8:29   ` [dpdk-dev] [PATCH v4 0/4] net/tap: support flow API Pascal Mazon
2017-03-14  8:29     ` [dpdk-dev] [PATCH v4 1/4] net/tap: move private elements to external header Pascal Mazon
2017-03-14 14:05       ` Wiles, Keith
2017-03-14  8:29     ` [dpdk-dev] [PATCH v4 2/4] net/tap: add preliminary support for rte_flow Pascal Mazon
2017-03-14  8:29     ` [dpdk-dev] [PATCH v4 3/4] net/tap: add netlink back-end for flow API Pascal Mazon
2017-03-14 14:03       ` Wiles, Keith
2017-03-14  8:29     ` [dpdk-dev] [PATCH v4 4/4] net/tap: add basic flow API patterns and actions Pascal Mazon
2017-03-15 14:54   ` [dpdk-dev] [PATCH v5 0/4] net/tap: support flow API Pascal Mazon
2017-03-15 14:54     ` [dpdk-dev] [PATCH v5 1/4] net/tap: move private elements to external header Pascal Mazon
2017-03-21 15:32       ` Wiles, Keith
2017-03-21 16:57         ` Pascal Mazon
2017-03-15 14:54     ` [dpdk-dev] [PATCH v5 2/4] net/tap: add preliminary support for rte_flow Pascal Mazon
2017-03-21 15:35       ` Wiles, Keith
2017-03-15 14:54     ` [dpdk-dev] [PATCH v5 3/4] net/tap: add netlink back-end for flow API Pascal Mazon
2017-03-15 14:54     ` [dpdk-dev] [PATCH v5 4/4] net/tap: add basic flow API patterns and actions Pascal Mazon
2017-03-21 17:10       ` Ferruh Yigit
2017-03-21 15:48     ` Wiles, Keith [this message]
2017-03-22  9:48   ` [dpdk-dev] [PATCH v6 0/4] net/tap: support flow API Pascal Mazon
2017-03-22  9:48     ` [dpdk-dev] [PATCH v6 1/4] net/tap: move private elements to external header Pascal Mazon
2017-03-22  9:48     ` [dpdk-dev] [PATCH v6 2/4] net/tap: add preliminary support for rte_flow Pascal Mazon
2017-03-22  9:48     ` [dpdk-dev] [PATCH v6 3/4] net/tap: add netlink back-end for flow API Pascal Mazon
2017-03-22  9:48     ` [dpdk-dev] [PATCH v6 4/4] net/tap: add basic flow API patterns and actions Pascal Mazon
2017-03-22 13:56       ` Ferruh Yigit
2017-03-22 14:22     ` [dpdk-dev] [PATCH v6 0/4] net/tap: support flow API Wiles, Keith
2017-03-23  8:33     ` [dpdk-dev] [PATCH v7 " Pascal Mazon
2017-03-23  8:33       ` [dpdk-dev] [PATCH v7 1/4] net/tap: move private elements to external header Pascal Mazon
2017-03-23  8:33       ` [dpdk-dev] [PATCH v7 2/4] net/tap: add preliminary support for rte_flow Pascal Mazon
2017-03-23  8:33       ` [dpdk-dev] [PATCH v7 3/4] net/tap: add netlink back-end for flow API Pascal Mazon
2017-03-23  8:33       ` [dpdk-dev] [PATCH v7 4/4] net/tap: add basic flow API patterns and actions Pascal Mazon
2017-03-23 12:50       ` [dpdk-dev] [PATCH v7 0/4] net/tap: support flow API Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1691FC7F-5C13-4F54-A5D1-CC30C7FE01FB@intel.com \
    --to=keith.wiles@intel.com \
    --cc=dev@dpdk.org \
    --cc=pascal.mazon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).