From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 24A523B5 for ; Tue, 21 Mar 2017 16:48:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490111327; x=1521647327; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=j833ZxCSS+Uk8Qfu7xCJPSzvc4nIR9pOMuQjDETYr9M=; b=L3F2VF+7/QGVx/2HOQWPpVkqLJvOsmemoW4Wg5c6SdE0Ru1o2wJzEA4T FtwkwN1lnnfqKKmOsn+rvYqMTBh/yg==; Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Mar 2017 08:48:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,198,1486454400"; d="scan'208";a="77802104" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga005.jf.intel.com with ESMTP; 21 Mar 2017 08:48:45 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 21 Mar 2017 08:48:45 -0700 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.175]) by FMSMSX109.amr.corp.intel.com ([169.254.15.99]) with mapi id 14.03.0319.002; Tue, 21 Mar 2017 08:48:44 -0700 From: "Wiles, Keith" To: Pascal Mazon CC: "dev@dpdk.org" Thread-Topic: [PATCH v5 0/4] net/tap: support flow API Thread-Index: AQHSnZw76Ov3Vc9SdEqOPDVvyhFRfqGf71sA Date: Tue, 21 Mar 2017 15:48:44 +0000 Message-ID: <1691FC7F-5C13-4F54-A5D1-CC30C7FE01FB@intel.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.84.105] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 0/4] net/tap: support flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2017 15:48:47 -0000 > On Mar 15, 2017, at 9:54 AM, Pascal Mazon wrote: >=20 > This series add support for the flow API in tap PMD. >=20 > It enables filtering specific packets incoming on the tap netdevice, to > process only desired ones. Under the hood, it uses kernel TC (traffic > control), which takes place very early in the stack, and supports most > common pattern items and actions defined in the flow API. >=20 > This series applies on top of: >=20 > [PATCH 0/6] net/tap: add additional management ops >=20 > v2 changes: > - support compilation on kernels < 4.2 (where flower support appeared) > - set whitespaces in tap.h > - remove unnecessary goto >=20 > v3 changes: > - vlan patterns enabled depending on running kernel (4.9+) > - update doc/guides/nics/tap.rst for Flow API support > - rebase on top of "net/tap: add additional management ops" series >=20 > v4 changes: > - rebase on top of "net/tap: add additional management ops" series > - fix a few netlink doxygen comments > - rename tap.h -> rte_eth_tap.h > - flush flow rules only when applicable >=20 > v5 changes: > - rebase after adrien's patches on Tx poll and Rx signaling > - better spaces for comments in rte_eth_tap.h >=20 > Pascal Mazon (4): > net/tap: move private elements to external header > net/tap: add preliminary support for rte_flow > net/tap: add netlink back-end for flow API > net/tap: add basic flow API patterns and actions >=20 > doc/guides/nics/features/tap.ini | 1 + > doc/guides/nics/tap.rst | 23 + > drivers/net/tap/Makefile | 44 ++ > drivers/net/tap/rte_eth_tap.c | 101 ++-- > drivers/net/tap/rte_eth_tap.h | 80 +++ > drivers/net/tap/tap_flow.c | 1078 +++++++++++++++++++++++++++++++++= +++++ > drivers/net/tap/tap_flow.h | 58 ++ > drivers/net/tap/tap_netlink.c | 367 +++++++++++++ > drivers/net/tap/tap_netlink.h | 69 +++ > drivers/net/tap/tap_tcmsgs.c | 378 +++++++++++++ > drivers/net/tap/tap_tcmsgs.h | 63 +++ > 11 files changed, 2227 insertions(+), 35 deletions(-) > create mode 100644 drivers/net/tap/rte_eth_tap.h > create mode 100644 drivers/net/tap/tap_flow.c > create mode 100644 drivers/net/tap/tap_flow.h > create mode 100644 drivers/net/tap/tap_netlink.c > create mode 100644 drivers/net/tap/tap_netlink.h > create mode 100644 drivers/net/tap/tap_tcmsgs.c > create mode 100644 drivers/net/tap/tap_tcmsgs.h >=20 > --=20 > 2.8.0.rc0 >=20 Going to Ack the series, but I am not an expert on flows. The only thing I = saw was the missing C++ ifdefs in the headers, if that is required, then yo= u can send that update in a new patch instead of reissuing this one, unless= you want. Acked-by: Keith.Wiles for the series. Regards, Keith