From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f174.google.com (mail-wr0-f174.google.com [209.85.128.174]) by dpdk.org (Postfix) with ESMTP id D68C32A6C for ; Thu, 6 Apr 2017 22:49:00 +0200 (CEST) Received: by mail-wr0-f174.google.com with SMTP id c55so6676299wrc.3 for ; Thu, 06 Apr 2017 13:49:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=GX5mqz/6xXdDmwJZqlnUOYUkFVBJeNGI4uBtUY4KcMI=; b=F8+K/SY51aeU/cYBv88KHhYO0QpDMezpX0mwBju8pSE6y20EFNWrc02dhk4uG62Kdr KTsXmqHNblkVPPIly+LTV5tUGHL+C2gyqrOnUyiQO6EDBnhD8S8xP2yQ3MD9d3rs3EVD c9C1ImfvZ46/k/+8E8t4Wp/U1UpFm6VdWaS1CR8U4v5517R22X5fwGW/QL/J0uXr50JZ J8MkRes+JBTCfeykbV2iP9t8QMhf+C2QN1fOA9IndZoVAl04QJmPJdok6cKfwS/1vIiS fyEE9COe11uxG3G+26USXFPV+ZOTmSihB0Suk0vua1UfzlyCHTJ3mTABJ2LOdgMpxDr6 nqFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=GX5mqz/6xXdDmwJZqlnUOYUkFVBJeNGI4uBtUY4KcMI=; b=dT9XR/z/APvOL47CkPbuNhpNwMnDzA90Jo2SqPYESaU2hWMJyZd7tX8l57XY3oNkv9 DFhrQzTa1eN6mZNBp7z9BempJ7YoBfr4Yz5bD59idIruKI7ZIPWPCjVEEYEB5oWC2qlV /0Nr5lvVHPXY487UwEOWh/oumjV6YCplM/H4ZdTLN+q5h1ZvFDLatw30f/2cSEV2Vwm4 5XNFuw7dObWasckkStI9FYr6414nj8ltaItVmGCYthwfcZ18PUPasJVPulcTC5gkC8SI pNbtMfISNzWURurH+12AXT93jTqhfzf2Rwp6sdWFSdiCrgUgKbUivSkkuzqUCooN66Ck GvPw== X-Gm-Message-State: AN3rC/4HnITScvqi2hK2QMWvZfpIqsBEdpCEgPSQxuv6o/5IIxQh7YJgU962NnNltW8XA9Di X-Received: by 10.223.154.70 with SMTP id z64mr4422544wrb.136.1491511740430; Thu, 06 Apr 2017 13:49:00 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id u145sm27651169wmu.1.2017.04.06.13.48.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Apr 2017 13:48:59 -0700 (PDT) From: Thomas Monjalon To: Andriy Berestovskyy Cc: dev@dpdk.org Date: Thu, 06 Apr 2017 22:48:58 +0200 Message-ID: <1692122.NGhiyjpKUa@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1490356325-15434-1-git-send-email-Andriy.Berestovskyy@caviumnetworks.com> References: <1490288768-8114-1-git-send-email-Andriy.Berestovskyy@cavium.com> <1490356325-15434-1-git-send-email-Andriy.Berestovskyy@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] ether: use a default for max Rx frame size in configure() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Apr 2017 20:49:01 -0000 2017-03-24 12:52, Andriy Berestovskyy: > At the moment rte_eth_dev_configure() behaves inconsistent: > - for normal frames: out of range max_rx_pkt_len uses a default > - for jumbo frames: out of range max_rx_pkt_len gives an error > > This patch fixes this inconsistency by using a default value > for max_rx_pkt_len both for normal and jumbo frames. > > Signed-off-by: Andriy Berestovskyy It is a bit strange to use the max value when the input is below the minimum. Anyway, why not fixing it in the reverse way: returning error for out of range of non-jumbo frames? I am not sure setting a default value in the back of the caller is really a good behaviour.