From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 22232A04F5;
Fri, 19 Jun 2020 00:48:55 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 06F69DE3;
Fri, 19 Jun 2020 00:48:55 +0200 (CEST)
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
[66.111.4.25]) by dpdk.org (Postfix) with ESMTP id DA1AD3B5
for <dev@dpdk.org>; Fri, 19 Jun 2020 00:48:53 +0200 (CEST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47])
by mailout.nyi.internal (Postfix) with ESMTP id 7C5AB5C01BF;
Thu, 18 Jun 2020 18:48:53 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute7.internal (MEProxy); Thu, 18 Jun 2020 18:48:53 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm1; bh=
HpZnPlPYAmL7KBeX/ygngUYiR29liNQAGuV/EszEjC0=; b=KYJPFnJC36LrYZCT
c94qTjHvPfSwGdF6wJ3ksj/quFlvJQk4sPGYqMiu9FZeo9FR5y9n2RLWI4YswMwf
LyxmiodRyNR9OOUy8GxsGJEMfia6HdI+faJq4h/L8M683ttMtWtuJrjsjWfk9st2
KjfgPgr0zgs8MGP4xD05MwyxvPQqFCmX6vrufGkJPADn+vEGECPdH/iF1mdvC+MS
FauGYMe9ipwFkaGnWZGQ5ojIuesBIdBgmyPON4NCcxYDuWiOOunaS0MkCY8OqZqS
UYCCFRg3JE0E5m6faZw+qsejlyp7q0ts3iXbAbc5X4+DH82AkT9HvnvikgdAMoeT
qgKSGg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm3; bh=HpZnPlPYAmL7KBeX/ygngUYiR29liNQAGuV/EszEj
C0=; b=kQ6pvoROw4e7yEs/JwMRXINXhuljaUHVTyOrnm4S9MXuFv78h6PEbRteB
ilmC63iPGgNzZdoO9w5WjJOa+h4BH2rznPxC8T4LVqmHYFnflmsPYD/MHh4z7eBB
bSclhMbhoWsnd09m6e8WCBBT2H7p9MtnSBa+3N4A5orqSc/QgEj1K5YGWYzDfYl1
iEDjZwfG7tXmNyFRGvBt2BQe3Z4U8aCPcnJmrhvho/YrqmsTxf0rBfpKVepY1MKV
yJEtKeT4Hbb20BB725CANbMG5nXaJ8rUQneyXgvWQkhRwjAFbI4YNG6F5uTjBLSl
V55mukVg/66E2tz9sg6jLfC3xA9cg==
X-ME-Sender: <xms:Ve_rXv78ge6hnz5OOKaQqqSa3Cbocwp_KyV3u32kw5NNxD1Ro215Cg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudejhedgudehucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
hiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
ohhnrdhnvght
X-ME-Proxy: <xmx:Ve_rXk4IwxzbSz47vZEHFuOGTGIzaBA0Wjt6-Nd9Hs8xYYO9Bt4ZeA>
<xmx:Ve_rXmf1yLvS8awkpCIgL44OQ0KH1dwrWEfz1g1kyg8hJTZr2Jw4Qg>
<xmx:Ve_rXgJz4lIWBK-43XTPm9cDKZIs6-ntukCvOm12cWYStvyI_C4IrA>
<xmx:Ve_rXpgcQE0E8U0czUIHBZeDE4Rlonu7Bvfczk5xy7XVR8GdbgWD1Q>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 93CA83280063;
Thu, 18 Jun 2020 18:48:52 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ophir Munk <ophirmu@mellanox.com>
Cc: dev@dpdk.org, Matan Azrad <matan@mellanox.com>,
Raslan Darawsheh <rasland@mellanox.com>, ferruh.yigit@intel.com
Date: Fri, 19 Jun 2020 00:48:50 +0200
Message-ID: <16932720.eeT1gxbM6y@thomas>
In-Reply-To: <3099190.lTHxlZXM2T@thomas>
References: <20200610093233.23902-1-ophirmu@mellanox.com>
<20200610093233.23902-8-ophirmu@mellanox.com> <3099190.lTHxlZXM2T@thomas>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v1 7/8] common/mlx5: exclude OS dependency in
devx commands
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
+Cc Ferruh for info
19/06/2020 00:47, Thomas Monjalon:
> 10/06/2020 11:32, Ophir Munk:
> > Shared function mlx5_devx_cmd_mkey_create() reads the OS pagesize by
> > calling a Linux API: 'sysconf(_SC_PAGESIZE)'. Wrap this call with a
> > shared API 'mlx5_os_get_page_size()' which contains the specific OS
> > implementation.
> >
> > Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
>
> Sorry, I drop this patch while pulling next-net.
>
> > +/**
> > + * Get OS page size
> > + *
> > + * @return
> > + * OS pagesize
> > + */
> > +size_t
> > +mlx5_os_get_page_size(void)
> > +{
> > + return sysconf(_SC_PAGESIZE);
> > +}
>
> The same purpose is achieved with rte_mem_page_size(),
> which was added in EAL recently for Windows memory management.
>
> In general, such basic need should not be implemented in a PMD.