From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2711EA0565;
	Mon, 23 Mar 2020 14:47:15 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 2B8491C068;
	Mon, 23 Mar 2020 14:47:14 +0100 (CET)
Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com
 [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id D20811C065
 for <dev@dpdk.org>; Mon, 23 Mar 2020 14:47:11 +0100 (CET)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47])
 by mailnew.nyi.internal (Postfix) with ESMTP id 2FFE758030F;
 Mon, 23 Mar 2020 09:47:11 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute7.internal (MEProxy); Mon, 23 Mar 2020 09:47:11 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=1zYHNSGgyPdwO3/fOVCRMsNN8qWGDjA/GxjUoLP2L64=; b=NogWiAs2oJQj
 MIn95wCMsjD4f4EE/8YXtf823ZrZSr92ZvI+ZFRG9rGo2KHLJuIjXXqPcKBYlsR9
 LH5SKXDKDFNAPkW7Xcd9lF6JVTjcMXFVaLiF8Lp+O4N3Y365JOwRPuBzMrH0z5p2
 OhmmdB96lrY0oHSbv55HFrczxUEoMRg=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=1zYHNSGgyPdwO3/fOVCRMsNN8qWGDjA/GxjUoLP2L
 64=; b=lfPnOewUjhtDuEHenDA7iOx6WK/EdTsBQH5SL/ElfMJjBLHyaGLWccfSt
 XfGvfsMg6BbBDXwxLF5+/8DkqP8LdRzefTGhE6k4pWfN40XnCwIrllevO9mSHj8p
 Yshkb2o3chql0D0xC2++UmH8ZYNbkq73HNikCY4oaAQ09IgoLnpFZ1HEfr+Xvce2
 RKtz2Kfv08uW2laRx8HuHZFV6kjaL7r2iIosKgNJ2h6kzNUXmgXoRJaHohixFxbk
 2bJxd6axDwV6DO1tehgUCKNl275r4CvMJXuLgrxUF3OfqcFrFBa6nx3oXpkh8vcw
 i4nK39qYvMjGo3HCLRV7GBL73b63Q==
X-ME-Sender: <xms:3r14XgA-YNXgW9aPr-cG1TjjXDodVjt0J03a27TYEYLJmnihbOkAsw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudegkedgheehucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff
 homhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrddvtdefrddukeegnecu
 vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrg
 hssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:3r14Xju50bYyCqIqc2iVObhj6kx5XKCEtM4OQn2FigEChNbgZkGrBQ>
 <xmx:3r14XkDK1RSZiIxot4Ra87hTwfa-S8ASZgvBZgVPphHX3AKhXCtH1Q>
 <xmx:3r14XgIhCGKDtsxDiytN3MAHNrC5aZuvTn39p4sBY6eyqsbv1QmIYQ>
 <xmx:3714XoBmdbY1EFNC63fWdqUiDYm1K0B4e65C2JbhHB-CgBg9lbYF_w>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 275F5328005D;
 Mon, 23 Mar 2020 09:47:09 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
 John McNamara <john.mcnamara@intel.com>,
 Marko Kovacevic <marko.kovacevic@intel.com>, Matan Azrad <matan@mellanox.com>,
 Shahaf Shuler <shahafs@mellanox.com>,
 Viacheslav Ovsiienko <viacheslavo@mellanox.com>,
 Gagandeep Singh <g.singh@nxp.com>, Hemant Agrawal <hemant.agrawal@nxp.com>,
 Sachin Saxena <sachin.saxena@nxp.com>,
 Harini Ramakrishnan <harini.ramakrishnan@microsoft.com>,
 Omar Cardona <ocardona@microsoft.com>, Pallavi Kadam <pallavi.kadam@intel.com>,
 Ranjit Menon <ranjit.menon@intel.com>
Date: Mon, 23 Mar 2020 14:47:07 +0100
Message-ID: <1693560.8hzESeGDPO@xps>
In-Reply-To: <CAJFAV8xbz+7gRO+4oTaM0MF4+r69w_2c+oSixH_44Zn1Rs5q4A@mail.gmail.com>
References: <20200217222654.2218926-1-thomas@monjalon.net>
 <CAJFAV8xbz+7gRO+4oTaM0MF4+r69w_2c+oSixH_44Zn1Rs5q4A@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] devtools: forbid variable declaration inside
	for
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

23/03/2020 14:40, David Marchand:
> On Mon, Feb 17, 2020 at 11:27 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > Some compilers raise an error when declaring a variable
> > in the middle of a function. This is a C99 allowance.
> > Even if DPDK switches globally to C99 or C11 standard,
> > the coding rules are for declarations at the beginning
> > of a block:
> > http://doc.dpdk.org/guides/contributing/coding_style.html#local-variables
> >
> > This coding style is enforced by adding a check of
> > the common patterns like "for (int i;"
> >
> > The occurrences of the checked pattern are fixed:
> >         'for *(\(char\|u\?int\|unsigned\)'
> 
> You missed size_t:
> drivers/common/mlx5/mlx5_glue.c:        for (size_t i = 0; i < num_actions; i++)

Good catch, thanks.

[..]
> > --- a/devtools/checkpatches.sh
> > +++ b/devtools/checkpatches.sh
> > +       # forbid variable declaration inside "for" loop
> > +       awk -v FOLDERS='.' \
> > +               -v EXPRESSIONS='for *\\((char|u?int|unsigned)' \
> 
> + s?size_t

OK

> > +               -v RET_ON_FAIL=1 \
> > +               -v MESSAGE='Declaring a variable inside for()' \
> > +               -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
> > +               "$1" || res=1
> > +
> 
> Just a note, base drivers imported "as is" will probably trigger warnings.

Yes, base drivers don't comply with coding rules and trigger lots of warnings.