From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DA48A04A2; Wed, 19 Jan 2022 17:53:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B65B41174; Wed, 19 Jan 2022 17:53:45 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 7110641147 for ; Wed, 19 Jan 2022 17:53:44 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id C890C3203193; Wed, 19 Jan 2022 11:53:42 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 19 Jan 2022 11:53:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= fxx886MUKEyMoXEq7dbhMjY6d9JgtS3YGOfZzMVgj8A=; b=Zkgmr3kLv6g6HSeG UvNxCn4F2c1Y4Avt/HSvejfVAqP+VeLBGqpNlhdQj6rABxD/eOOoeHBjsnMfwPRe vDXHu8DF4U9+7hpdRMU8h0uvgAlM/zFrDa+OAHfwk2CAgQlwtJDUqVWDEWR3/kLP 0vNOmHevzQlUn+CvKg/q8xMfVaG8gp8DoU1SH/OQnqaS4m8YSugDRcnk3J1YwZIn keUAPt0vhfCxMKM+4R+ZtPVeTjCdxJmJKwZVyf6cr8BXNc7Q/uN6sBDNN14MIo6M Or3QgnA/SuvwAMXjqjRh/6+9bNCIo7rF3CgkZFSG2vfRwyriJL1TjeeewSSfIFxR QYrVeg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=fxx886MUKEyMoXEq7dbhMjY6d9JgtS3YGOfZzMVgj 8A=; b=c0rzIq1rwq54KjWtYl3W+zbV1imgp4mX6WhCFxOcazvXvEAkzzave8C1/ xomDtRDFozhsGBnMr67uUsS+8tHPV2oUGIsuNILwRUol1L0Tz++4fTFtVOhBUVWj JF/xi/fCjCrRkJv+eB2fkP+A74Zm9Sw2JMvbXsSw3vCYObqOFE2EdNI3v5VlbgCx RWIMwNNBBLB9dijWYgMyLL9KJwNuWcE+JzOnQdEq5BKt9Sszj/+Xw20fX5g0j4bd IhdSRyWvdXC7Al1NrsTmKh9VhEUpA3ngVhgcFgmBPQtYlKeTJ5HWI77rUcqNU7u5 1AlhvDndt2v5sn6bz5gN3kGqTynCw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeigdefhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 19 Jan 2022 11:53:41 -0500 (EST) From: Thomas Monjalon To: Maxime Gouin Cc: "dev@dpdk.org" , "Zhang, Qi Z" , "Zhang, Tianfei" , Olivier Matz , "Huang, Wei" , "Xu, Rosen" Subject: Re: [PATCH] bus/ifpga: remove useless check while browsing devices Date: Wed, 19 Jan 2022 17:53:39 +0100 Message-ID: <1693683.K4a6FZZPjd@thomas> In-Reply-To: References: <20220105102652.6400-1-maxime.gouin@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > reported by code analysis tool C++test (version 10.4): > > > > > /build/dpdk-20.11/drivers/bus/ifpga/ifpga_bus.c > > > 67 Condition "afu_dev" is always evaluated to true > > > 81 Condition "afu_dev" is always evaluated to true > > > > The "for" loop already checks that afu_dev is not NULL. > > > > Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library") > > > > Signed-off-by: Maxime Gouin > > Reviewed-by: Olivier Matz > > Acked-by: Rosen Xu Applied, thanks