From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B76B3A053A; Thu, 23 Jan 2020 16:49:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6A2C32956; Thu, 23 Jan 2020 16:49:37 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 4ECF827D for ; Thu, 23 Jan 2020 16:49:35 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E193421D28; Thu, 23 Jan 2020 10:49:34 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 23 Jan 2020 10:49:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=MvGnBsi9HpQwcZnP8rZkShXABe9D/8o69ZJ0gfIEEG8=; b=nJ72tITahR5p Sg1HZwkG4gdb4FKsoDMOUQaViPxh9c9NKkprIHyF6lgTnQNCVYngmZe0Fhkb8zN0 +Wx/s1OhNH34nrx/5IVlclvS8t55+wDyUI+Iph3jhUko4w97DG0Enwn4bW8TZPdX qHoRuxJ7ZMj8sCd5Aj7uRIG9bI93zJY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=MvGnBsi9HpQwcZnP8rZkShXABe9D/8o69ZJ0gfIEE G8=; b=O4SBKrMNDzKGmSIldvxSAy/OReyTkMwVNZYy8RAA5dDoVIREZ8mUpSEmj L8BIuuAMVyYOPp7w2zkj+w32ZxhIAkaNGBaFdB+DTbjaNVVtKuLfVMOt+TZPml71 6a6Nl5x7mgzjd+M/yN1oPdtCOJBunvl33n6jbXSaeDbRFANEZXllkIyV2gAovsAx WIkWJu+KjLaIyQkN7BMPGpLJSaHZk548QSNmE9+qtPDXegWwcSs4JRk4KmhOvAl3 XA4JtrDARvwuvwyU9JJs3Bk4tdVWziuJdgkQik7ftGR65scoQNgTy+SAXONWF1ia JLuRSKx5WsoMKNqANobTVwwXaOmmQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrvddvgdeglecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A5A893060A6E; Thu, 23 Jan 2020 10:49:33 -0500 (EST) From: Thomas Monjalon To: Alexander Kozyrev Cc: dev@dpdk.org, rasland@mellanox.com, matan@mellanox.com, viacheslavo@mellanox.com, ferruh.yigit@intel.com Date: Thu, 23 Jan 2020 16:49:32 +0100 Message-ID: <1694297.CLbsiaQdQ3@xps> In-Reply-To: <1579789555-23239-4-git-send-email-akozyrev@mellanox.com> References: <1579789555-23239-1-git-send-email-akozyrev@mellanox.com> <1579789555-23239-4-git-send-email-akozyrev@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 3/5] net/mlx4: introduce the mlx4 version of the assert X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/01/2020 15:25, Alexander Kozyrev: > Use the MLX4_ASSERT macros instead of the standard assert clause. > Depends on the MLX4_DEBUG configuration option to define it as the > RTE_ASSERT or an empty clause for a release configuration. > > Signed-off-by: Alexander Kozyrev > Acked-by: Viacheslav Ovsiienko > --- I think it would be good to explain that assert can be enabled either globally or with a specific define. More details below: In case mlx4 debug is enabled (from global meson debug or specific define), the assert is enabled by calling RTE_VERIFY which bypasses the global option CONFIG_RTE_ENABLE_ASSERT. > +#define MLX4_ASSERT(exp) RTE_VERIFY(exp) [...] In case mlx4 debug is disabled, the global option CONFIG_RTE_ENABLE_ASSERT can still enable assert by calling RTE_VERIFY inside RTE_ASSERT macro. > #else /* MLX4_DEBUG */ [...] > +#define MLX4_ASSERT(exp) RTE_ASSERT(exp)