From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 782B31C01 for ; Thu, 26 Jul 2018 19:18:27 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id F0BCB21D1F; Thu, 26 Jul 2018 13:18:26 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 26 Jul 2018 13:18:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=nyN0ViIpJbLstjqRFg1N2Rj9QA n8ZhWQHM12VdKcySI=; b=JBJU4TirT6uWZyN8wtuixdg7OsjxMPjJ5TXrZjD5Sr rAfEmlNLjq6lbZV+LsR1gKL0Pv1GCx+ymaHA/v7gC2Kjfx5nUlYMeS6ybpSU7lBb hvy6rVoeSHlO5i+0T9GF18jX+vwu6YnzZR/ta77YV0DbH9v91cG4AF0bYCuNSm8k E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=nyN0Vi IpJbLstjqRFg1N2Rj9QAn8ZhWQHM12VdKcySI=; b=jiu1kvWNIbxoCOKCP7XUBq tb7Ztlb/twpbs/utHf9M4P/ITZ6qddnnl5WyM26PthPp36kDaDAacaDt+aJFLElL 57+5ZUym/nLhc/5dtKC6tMajc6VeQJiSsw6abNWqL25kIadwHhNBRQawMuGETG1n ZeIHO/3zptItsPyCDmVgICVycS/eINw21vhYxRMxYH2EiTm2jPPCGki7mZFjm7La NkRFGhYBUuUQtoT/YlTO2du7QOpSSYxFXmc0k5yVq2TnQPWocjUdJ+Qt1XzE5IMh 5n4al8+J7dZKISrGVIcsvUVQSQk7vGi/zYC5NjuLPSkBdb1UOhFvFaJW+KU5Exag == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 944FD1026B; Thu, 26 Jul 2018 13:18:25 -0400 (EDT) From: Thomas Monjalon To: "Iremonger, Bernard" , "Li, Xiaoyun" Cc: "Lu, Wenzhuo" , "Wu, Jingjing" , "dev@dpdk.org" , ferruh.yigit@intel.com Date: Thu, 26 Jul 2018 19:18:20 +0200 Message-ID: <1694337.hYEmcJhZCz@xps> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260CCF024@IRSMSX107.ger.corp.intel.com> References: <1532431954-123708-1-git-send-email-xiaoyun.li@intel.com> <8CEF83825BEC744B83065625E567D7C260CCF024@IRSMSX107.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix dcb config failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jul 2018 17:18:27 -0000 > > After adding RSS hash offload check, default rss_hf will fail on devices that do > > not support all bits. This will lead to dcb config failure. The patch fixes this > > issue by taking rss_hf as a suggested value and only setting bits that the > > device supports based on rte_eth_dev_get_info. > > > > Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check") > > Fixes: 1a572499beb6 ("app/testpmd: setup DCB forwarding based on traffic > > class") > > Cc: stable@dpdk.org > > > > Signed-off-by: Xiaoyun Li > > Acked-by: Bernard Iremonger NACK testpmd is a test application for developpers. It must fail if the PMD cannot support user-requested features. For other applications, there can be a smooth fallback if and only if there are appropriate logs. This is what Ferruh did for examples: http://git.dpdk.org/dpdk/commit/?id=4f5701f28bd