From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, david.marchand@redhat.com,
Bruce Richardson <bruce.richardson@intel.com>,
stable@dpdk.org, Ray Kinsella <mdr@ashroe.eu>,
Neil Horman <nhorman@tuxdriver.com>,
Kevin Laatz <kevin.laatz@intel.com>
Subject: Re: [dpdk-dev] [PATCH] eal: fix querying DPDK version at runtime
Date: Fri, 05 Feb 2021 21:05:43 +0100 [thread overview]
Message-ID: <1695007.lsEMqjsl9x@thomas> (raw)
In-Reply-To: <20210205193933.410011-1-bruce.richardson@intel.com>
05/02/2021 20:39, Bruce Richardson:
> For using a DPDK application, such as OVS, which is dynamically linked, the
> DPDK version in use should always report the actual version, not the
> version used at build time. This incorrect behaviour can be seen by
> building OVS against one version of DPDK and running it against a later
> one. Using "ovs-vsctl list Open_vSwitch" to query basic info, the
> dpdk_version returned will be the build version not the currently running
> one - which can be verified using the DPDK telemetry library client.
>
> $ sudo ovs-vsctl list Open_vSwitch | grep dpdk_version
> dpdk_version : "DPDK 20.11.0-rc4"
>
> $ echo quit | sudo dpdk-telemetry.py
> Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2
> {"version": "DPDK 21.02.0-rc2", "pid": 405659, "max_output_len": 16384}
Nice demonstration.
> __rte_experimental
> int
> -rte_telemetry_init(const char *runtime_dir, rte_cpuset_t *cpuset,
> +rte_telemetry_init(const char *runtime_dir, const char *rte_version, rte_cpuset_t *cpuset,
> const char **err_str);
It is changing the API.
As it is experimental, you just need to mention it in the release notes.
It is the fix. Do you think it should be merged quickly?
Or wait for 21.05?
next prev parent reply other threads:[~2021-02-05 20:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 19:39 Bruce Richardson
2021-02-05 20:05 ` Thomas Monjalon [this message]
2021-02-05 21:26 ` Bruce Richardson
2021-02-09 12:34 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2021-02-09 12:36 ` Bruce Richardson
2021-02-16 15:13 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
2021-03-15 22:24 ` Thomas Monjalon
2021-03-17 8:40 ` David Marchand
2021-03-17 9:33 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1695007.lsEMqjsl9x@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).