DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] scripts: fix quiet checkpatch
@ 2016-11-02 16:10 Thomas Monjalon
  2016-11-05 14:58 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Monjalon @ 2016-11-02 16:10 UTC (permalink / raw)
  To: dev

The commit e13fbc065c7f ("scripts: improve quiet checkpatch")
removed the line "total: 1 errors, 0 warnings, 7 lines checked"
from the quiet report.
Later, commit e7c38f471384 ("scripts: remove useless checkpatch notes")
removed few lines before "total:.*lines checked", so it was not working
well for quiet reporting.

Better to keep the "total:" line in quiet mode and remove the other ones.
That's why the checkpatch.pl option --no-summary is not used anymore
by reverting the commit "improve quiet checkpatch".

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 scripts/checkpatches.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatches.sh b/scripts/checkpatches.sh
index 622a5b6..5286fe6 100755
--- a/scripts/checkpatches.sh
+++ b/scripts/checkpatches.sh
@@ -64,7 +64,7 @@ verbose=false
 while getopts hn:qv ARG ; do
 	case $ARG in
 		n ) number=$OPTARG ;;
-		q ) quiet=true && options="$options --no-summary" ;;
+		q ) quiet=true ;;
 		v ) verbose=true ;;
 		h ) print_usage ; exit 0 ;;
 		? ) print_usage ; exit 1 ;;
-- 
2.7.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] scripts: fix quiet checkpatch
  2016-11-02 16:10 [dpdk-dev] [PATCH] scripts: fix quiet checkpatch Thomas Monjalon
@ 2016-11-05 14:58 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2016-11-05 14:58 UTC (permalink / raw)
  To: dev

2016-11-02 17:10, Thomas Monjalon:
> The commit e13fbc065c7f ("scripts: improve quiet checkpatch")
> removed the line "total: 1 errors, 0 warnings, 7 lines checked"
> from the quiet report.
> Later, commit e7c38f471384 ("scripts: remove useless checkpatch notes")
> removed few lines before "total:.*lines checked", so it was not working
> well for quiet reporting.
> 
> Better to keep the "total:" line in quiet mode and remove the other ones.
> That's why the checkpatch.pl option --no-summary is not used anymore
> by reverting the commit "improve quiet checkpatch".
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-11-05 14:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-02 16:10 [dpdk-dev] [PATCH] scripts: fix quiet checkpatch Thomas Monjalon
2016-11-05 14:58 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).