From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Konstantin Ananyev <konstantin.ananyev@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCHv2] headers: typeof -> __typeof__ to unbreak C++11 code
Date: Mon, 09 Mar 2015 17:38:22 +0100 [thread overview]
Message-ID: <1696132.Xgpkj7r3Jx@xps13> (raw)
In-Reply-To: <1425657587-23516-1-git-send-email-konstantin.ananyev@intel.com>
2015-03-06 15:59, Konstantin Ananyev:
> v2:
> Instead of changing all the affected files,
> define 'typeofi' and 'asm' if needed.
>
> When compiling C++11-code or above (--std=c++11), the build fails with
> lots of
>
> rte_eth_ctrl.h:517:3: note: in expansion of macro RTE_ALIGN
> (RTE_ALIGN(RTE_ETH_FLOW_MAX, UINT32_BIT)/UINT32_BIT)
> ^
>
> When reading the GCC info pages, I get the feeling that __typeof__ is
> a better choice, and that indeed works when including the headers in
> C++ files (--std=c++11).
>
> There are some typeof()s left in C files, the patch only touches the
> public API.
>
> Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Applied, thanks
prev parent reply other threads:[~2015-03-09 16:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 13:28 [dpdk-dev] [PATCH] " Simon Kagstrom
2015-02-26 11:14 ` Thomas Monjalon
2015-02-26 11:24 ` Simon Kågström
2015-02-26 16:02 ` Mcnamara, John
2015-02-27 16:24 ` Ananyev, Konstantin
2015-03-02 7:55 ` Simon Kågström
2015-03-06 8:28 ` Simon Kågström
2015-03-06 10:30 ` Ananyev, Konstantin
2015-03-06 13:42 ` Simon Kågström
2015-03-06 15:59 ` [dpdk-dev] [PATCHv2] " Konstantin Ananyev
2015-03-09 16:38 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1696132.Xgpkj7r3Jx@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).