DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>,
	"Kinsella, Ray" <ray.kinsella@intel.com>,
	mdr@ashroe.eu
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	Akhil Goyal <akhil.goyal@nxp.com>,
	"aconole@redhat.com" <aconole@redhat.com>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v7 1/2] cryptodev: support enqueue and dequeue callback functions
Date: Wed, 20 Jan 2021 14:15:34 +0100
Message-ID: <1697053.2DkutoUMdu@thomas> (raw)
In-Reply-To: <PH0PR11MB477627829AA42F4556DF92A190A20@PH0PR11MB4776.namprd11.prod.outlook.com>

20/01/2021 14:01, Kinsella, Ray:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 15/01/2021 17:01, Akhil Goyal:
> > > > This patch adds APIs to add/remove callback functions on crypto
> > > > enqueue/dequeue burst. The callback function will be called for
> > each
> > > > burst of crypto ops received/sent on a given crypto device queue
> > > > pair.
> > > >
> > > > Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> > > > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> > > > ---
> > > Series applied to dpdk-next-crypto
> > 
> > 
> > It is missing a rule to ignore the false positive ABI break:
> > 
> > --- a/devtools/libabigail.abignore
> > +++ b/devtools/libabigail.abignore
> > @@ -11,3 +11,8 @@
> >  ; Explicit ignore for driver-only ABI
> >  [suppress_type]
> >          name = eth_dev_ops
> > +
> > +; Ignore fields inserted in cacheline boundary of rte_cryptodev
> > +[suppress_type]
> > +        name = rte_cryptodev
> > +        has_data_member_inserted_between = {0, 1023}
> > 
> 
> This is a bit of a blunt instrument as the range quiet large?

The range is in bits. It matches the actual size of the struct
for 64B cacheline.

> {offset_after(attached), end} instead works better - I will send a patch.

Yes that's exactly what David told me earlier today.

> > I'll add this change while pulling in the main tree.

Yes please.
Note: we missed requiring this exception rule in the original patch.



  parent reply	other threads:[~2021-01-20 13:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-22 14:42 [dpdk-dev] [PATCH v7 0/2] support enqueue & dequeue callbacks on cryptodev Abhinandan Gujjar
2020-12-22 14:42 ` [dpdk-dev] [PATCH v7 1/2] cryptodev: support enqueue and dequeue callback functions Abhinandan Gujjar
2021-01-04  6:59   ` Gujjar, Abhinandan S
2021-01-11 19:14   ` Akhil Goyal
2021-01-15 16:01   ` Akhil Goyal
2021-01-19 18:31     ` Thomas Monjalon
2021-01-20 13:01       ` Kinsella, Ray
2021-01-20 13:12         ` David Marchand
2021-01-20 13:15         ` Thomas Monjalon [this message]
2021-01-20 14:09           ` Kinsella, Ray
2020-12-22 14:42 ` [dpdk-dev] [PATCH v7 2/2] test: add testcase for crypto enqueue and dequeue callback Abhinandan Gujjar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1697053.2DkutoUMdu@thomas \
    --to=thomas@monjalon.net \
    --cc=abhinandan.gujjar@intel.com \
    --cc=aconole@redhat.com \
    --cc=akhil.goyal@nxp.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=mdr@ashroe.eu \
    --cc=ray.kinsella@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git