From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 678FA58C3 for ; Fri, 27 Nov 2015 19:51:37 +0100 (CET) Received: by wmww144 with SMTP id w144so67991166wmw.0 for ; Fri, 27 Nov 2015 10:51:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=TUInkrYXSDS9xUlfzh8egV6HmvjLQu9NNL6KLQPSlXY=; b=gfz+m+hzlgm6jj9OX7dkiAVWYXAnXBVU/kappRukDTYKThMuBUsmLcdUnJA6YOSKXz 8bCDccHEm6wwsyuwokuzXC+JocYHdy3EqL1DqE9tPkTeiAc9wDEyxS31U4EEaWHR3eHB 6usQPR5IN7CpLGPmJn8BmAxJa5p49G66chZf8gae1cZVebHnPZ+ToIp4odtibo9l5SR6 Gdz5yk2EmjBOqMWYav/y6JM42ufbDb12Hy01Uz1a0VtdK+N/2j4tmaB6nQ5UKIzKry2H GI/+y3ZhfzM5qv32EXZ09Ris6LAFRDzbD4+MywwlPMyXheOPzcDtUFw0lqa6FugehspS gtzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=TUInkrYXSDS9xUlfzh8egV6HmvjLQu9NNL6KLQPSlXY=; b=e/yTdP1ONWBUTbmFgCfnwXtV9ZUbycc6MlqA7sLxJkdvIkI7K3Dy4bflR52t0DxBsm ek4lGmQbRB1KAP2LNBQ2WxdQ6Ig/v1lZJLWC5+dzeuD4WwAZ9BOkHXHXumizDiAOfYPF AJ3Nj+PAVWXUBaeCBT2+VofKnPVBfUoiw3moMWKF1MNQr+TachLhETdDanZhHa/DQAO7 4/tBG2GYOdxDQofCZACebXAwll/AkzjR6og3evVoFcyQln9G0LkeUsNTVzQOPYoiME1u I7tmnu7K4kBHaoqEPN+Am8hGL1XbTKOn4LBqKbbd9dp4JEV6kdygt8hTN4v7mzOosO9U 6nyg== X-Gm-Message-State: ALoCoQmXM0sg8aGbJlBwhrIRhxu7Jzy0kRpPPEW6UlOPcDZh/Dj+HFQIs9GT3PbP5Ak7xKJ1PI/u X-Received: by 10.194.19.100 with SMTP id d4mr58505368wje.18.1448650297239; Fri, 27 Nov 2015 10:51:37 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id d2sm34058397wjy.16.2015.11.27.10.51.36 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 27 Nov 2015 10:51:36 -0800 (PST) From: Thomas Monjalon To: "Chen Jing D(Mark)" Date: Fri, 27 Nov 2015 19:50:17 +0100 Message-ID: <1697422.A7HKKzriin@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1448589345-16239-1-git-send-email-jing.d.chen@intel.com> References: <1448589345-16239-1-git-send-email-jing.d.chen@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] fm10k: fix wrong Rx func is used X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2015 18:51:37 -0000 2015-11-27 09:55, Chen Jing D: > From: "Chen Jing D(Mark)" > > Steps to reproduce the bug: > 1. All Rx offloading is disabled and start the device, then > Vector Rx is used. > 2. Stop the device. Re-configure to enable hw_ip_checksum = 1, > start the device again. > 3. In this case, assume regular Rx should be used since Vector > Rx doesn't support ip checksum offload. But actually Vector > Rx is used and cause checksum won't be done by hardware. > > The reason is after re-configuring, driver misses an "else" in > func fm10k_set_rx_function(). Then Rx func in last round are > used. > > Fixes:77a8ab47("fm10k: select best Rx function") git log -1 --abbrev=12 --format='Fixes: %h ("%s")' 77a8ab47 Fixes: 77a8ab47eb38 ("fm10k: select best Rx function") > Reported-by: Xiao Wang > Signed-off-by: Chen Jing D(Mark) Acked-by: Xiao Wang Applied, thanks