From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id CF5272B8E for ; Mon, 11 Jul 2016 07:56:19 +0200 (CEST) Received: by mail-wm0-f48.google.com with SMTP id f65so50183690wmi.0 for ; Sun, 10 Jul 2016 22:56:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=ee31jyTOEG6ytibDH966qWSyTxRGQY7wSmbE0F3gCYk=; b=qylYYNPUbqq41+gf/q/tbJQahNRE3TRKkQ6k+66aFHRHtDI7uqQoFY6qzsDx5QSI8g c5kuB0CmQk7S1DC0bjzgFVWFnuB1zYf+TuAtfjgTe4qZ2BvPdvY9Oz3fHw9hjF/F/kmy zp9e8jSxPzzVsV4MWi6yRDXGXP0LpGI0wmzkHw0NZt/BfGNA+yHSMgZkiODhVLUbEGki VUJ+P0/M+3jJMY+Po90hT+6V8R8X923AUTqPae/uYYlIRRy9FV5k+GnjCezJhTa9JHOu tMukhLBmo+uz4qT1EGlMgFsVTIZNvCS0o17SiIWueXFHctmDMHcxPaF3CSJOCEYluWSD H2kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=ee31jyTOEG6ytibDH966qWSyTxRGQY7wSmbE0F3gCYk=; b=DXpshSO8fazxOJEAmy1Le4ZYJ/I76jmXuS/SAKJVYczPD35YIOzs5QWzzq0vmZ81lV ZCTRA/fAeD7c9fe6QX77AfcjYccMzw16fqMeBicQJpJ/1bFfCK2tyo+aqx+F4DiL4CQ3 AkAh5ayqWtD4dxOGPiTbF8WBR6C55yseAQ++AiynQCJFxBUnjQP+ciYKpXoIv6zZmRpD UCZ+1a6KTJTgKqZWDo2Clva31xPy29QaWWUrRsS/6tWLxakppeMcJ1dlke/gE6X0qL4g bEZYQ1HqtF1dNh5GItjDc6WofE2+Wl3D/zLUDMG16R6KZ1CfneiQZdU9KP7LbapFqhAd 1FRA== X-Gm-Message-State: ALyK8tJbZTa8+i72hJ3bEoIH6YELkbA3qtGohWyO6UD+NCTlNSTYX1Ol1LT0CQ0iBu9sM6EH X-Received: by 10.28.140.194 with SMTP id o185mr15587132wmd.86.1468216579534; Sun, 10 Jul 2016 22:56:19 -0700 (PDT) Received: from xps13.localnet (110.204.154.77.rev.sfr.net. [77.154.204.110]) by smtp.gmail.com with ESMTPSA id 12sm13580652wmj.19.2016.07.10.22.56.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Jul 2016 22:56:18 -0700 (PDT) From: Thomas Monjalon To: Yuanhan Liu Cc: dev@dpdk.org, David Marchand , stephen@networkplumber.org, bruce.richardson@intel.com, nhorman@tuxdriver.com, pmatilai@redhat.com, christian.ehrhardt@canonical.com, Wenzhuo Lu , ferruh.yigit@intel.com, Rasesh Mody , johndale@cisco.om, Yong Wang Date: Mon, 11 Jul 2016 07:56:16 +0200 Message-ID: <1698058.nWbIbKdPp2@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160711053326.GW26521@yliu-dev.sh.intel.com> References: <1453120248-28274-1-git-send-email-david.marchand@6wind.com> <2858831.tSF8KXeB50@xps13> <20160711053326.GW26521@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 01/13] e1000: move pci device ids to driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jul 2016 05:56:20 -0000 2016-07-11 13:33, Yuanhan Liu: > On Fri, Jul 08, 2016 at 03:31:27PM +0200, Thomas Monjalon wrote: > > 2016-04-20 14:43, David Marchand: > > > test application and kni still want to know e1000 pci devices. > > > So let's create headers in the driver that will be used by them. > > > > There is also an usage of ixgbe ID for the broken bypass API. > > > > Sharing those PCI ids outside of the drivers was really a wrong idea. > > So this a plan to get rid of them: > > > > 1/ remove need in PCI autotest (done: http://dpdk.org/commit/1dbba165) > > 2/ move PCI ids in bnx2x, bnxt, e1000, enic, fm10k, i40e, virtio, vmxnet3 > > 3/ remove KNI ethtool (only igb/ixgbe support) > > 4/ remove bypass API or move it to ixgbe specific API > > 5/ move remaining PCI ids in igb and ixgbe drivers > > > > Please driver maintainers, move your PCI ids in your drivers as soon as > > possible. Thanks > > Hi Thomas, > > I'm not quite sure I understood it well: are you asking us to resend > what David has already send, say me for resending the virtio part? > > If so, what's the point of that? What's worse, it's likely to fail > apply (due to conflicts), as every one of us make a patch based on > the same base while touching some same files. Good point. There were some changes since the patches from David (and a new bnxt). That's why I was thinking to ask maintainers to take care of this change. But maybe it's better to do the change in one patchset. David, ok to refresh these patches?