From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id F090E1DBF for ; Mon, 23 Apr 2018 10:05:48 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2D43621B4E; Mon, 23 Apr 2018 04:05:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 23 Apr 2018 04:05:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=qKUwnUCICqwywbrIY6808gaUel 1eMUY0EQ9oO1SWCFw=; b=GsZqKgpieCojrFAfDVdco8/F1Q6wX6NcOaP7eyMJ0o fTNvgcXnVYs5YpIAqd/4x9XLV7B3U3kyfE/WX7YV+jYmhyaKsuz6jyAiFue6bT5a 1Lr+i4XC+geqK3Usqx+7UPVn7HsSHoNjg0GFfVxTbsF8XNLlPPhHlodDk+JTjSVg M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=qKUwnU CICqwywbrIY6808gaUel1eMUY0EQ9oO1SWCFw=; b=hywv/GEi4k5QJ+90oIwL4a 3gwsruTQ+DSayJXu1pwVkB18awxiAWvgH90ZXVAQTBmkaypL4Rd3JTMxsL7ENI4e lP6rXWHmr+cOfxWXCopK9FuD3Uut/w7pg7K8CzLxUtrlHsdWWYVaQFKt7DRgoAKH x3TXF2CU6MY2NX4rL6Sc8gKNIgLNQeiYyAo+xZEs9M4NhI/le6jCVfV7N+XQVEsl j8AexuYc9BrxnXloz6Ks71qUMKp07o6fBmWXLxfnPf/iCRKvVTbv8moXMnpz7teW HQ0nsVTFQziN1z6BR8vcYZ6MHxXjRsdDwqB9ZAJ24bPy8ym0KeIVsfBZ6j+A7pXg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 58A02E4B94; Mon, 23 Apr 2018 04:05:47 -0400 (EDT) From: Thomas Monjalon To: "Kumar, Ravi1" Cc: "pablo.de.lara.guarch@intel.com" , "dev@dpdk.org" , "hemant.agrawal@nxp.com" Date: Mon, 23 Apr 2018 10:05:46 +0200 Message-ID: <1698373.c9XDPgIzTm@xps> In-Reply-To: References: <1520584520-130522-1-git-send-email-Ravi1.kumar@amd.com> <14946114.ASIPbkMQcp@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 17/19] crypto/ccp: support cpu based md5 and sha2 family authentication algo X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2018 08:05:49 -0000 23/04/2018 08:41, Kumar, Ravi1: > >> +CONFIG_RTE_LIBRTE_PMD_CCP_CPU_AUTH=n > > > >Why introducing a compile-time option? > >Can it be a run-time option of the device? > >We must not add compile-time device option if not well justified. [...] > By default, all the crypto operations (cipher + auth) are offloaded to CCP engines. When user enables CONFIG_RTE_LIBRTE_PMD_CCP_CPU_AUTH=y, the auth operations are not offloaded to CCP and rather performed over CPU. We kept this feature as a compile time option in order to let user decide whether to run auth operations on CCP or CPU as some of the auth operations performs faster on CPU as compared to their performance on CCP. No, you do not let the user decide. The compilation options are for the packager to decide. The user can rely on pre-compiled packages and use only runtime options. That's why we forbid compile-time options for such features.