* [PATCH] eal: fix msvc conditional compile of rte atomic thread fence
@ 2023-11-07 20:00 Tyler Retzlaff
2023-11-08 8:27 ` Morten Brørup
0 siblings, 1 reply; 3+ messages in thread
From: Tyler Retzlaff @ 2023-11-07 20:00 UTC (permalink / raw)
To: dev
Cc: Morten Brørup, Bruce Richardson, Konstantin Ananyev, Tyler Retzlaff
MSVC does not expose legacy atomics. When the legacy atomics were
excluded rte_atomic_thread_fence was also unintentionally excluded
Adjust the conditional compilation check to expose
rte_atomic_thread_fence.
Fixes: 27da6a123414 ("eal: hide legacy atomics API for MSVC")
Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
lib/eal/x86/include/rte_atomic.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/eal/x86/include/rte_atomic.h b/lib/eal/x86/include/rte_atomic.h
index f754423..74b1b24 100644
--- a/lib/eal/x86/include/rte_atomic.h
+++ b/lib/eal/x86/include/rte_atomic.h
@@ -83,8 +83,6 @@
#define rte_io_rmb() rte_compiler_barrier()
-#ifndef RTE_TOOLCHAIN_MSVC
-
/**
* Synchronization fence between threads based on the specified memory order.
*
@@ -101,6 +99,8 @@
__rte_atomic_thread_fence(memorder);
}
+#ifndef RTE_TOOLCHAIN_MSVC
+
/*------------------------- 16 bit atomic operations -------------------------*/
#ifndef RTE_FORCE_INTRINSICS
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] eal: fix msvc conditional compile of rte atomic thread fence
2023-11-07 20:00 [PATCH] eal: fix msvc conditional compile of rte atomic thread fence Tyler Retzlaff
@ 2023-11-08 8:27 ` Morten Brørup
2023-11-08 13:40 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Morten Brørup @ 2023-11-08 8:27 UTC (permalink / raw)
To: Tyler Retzlaff, dev; +Cc: Bruce Richardson, Konstantin Ananyev
> From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com]
> Sent: Tuesday, 7 November 2023 21.00
>
> MSVC does not expose legacy atomics. When the legacy atomics were
> excluded rte_atomic_thread_fence was also unintentionally excluded
>
> Adjust the conditional compilation check to expose
> rte_atomic_thread_fence.
>
> Fixes: 27da6a123414 ("eal: hide legacy atomics API for MSVC")
>
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> ---
Acked-by: Morten Brørup <mb@smartsharesystems.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] eal: fix msvc conditional compile of rte atomic thread fence
2023-11-08 8:27 ` Morten Brørup
@ 2023-11-08 13:40 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2023-11-08 13:40 UTC (permalink / raw)
To: Tyler Retzlaff
Cc: dev, Bruce Richardson, Konstantin Ananyev, Morten Brørup
08/11/2023 09:27, Morten Brørup:
> > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com]
> > Sent: Tuesday, 7 November 2023 21.00
> >
> > MSVC does not expose legacy atomics. When the legacy atomics were
> > excluded rte_atomic_thread_fence was also unintentionally excluded
> >
> > Adjust the conditional compilation check to expose
> > rte_atomic_thread_fence.
> >
> > Fixes: 27da6a123414 ("eal: hide legacy atomics API for MSVC")
> >
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-08 13:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-07 20:00 [PATCH] eal: fix msvc conditional compile of rte atomic thread fence Tyler Retzlaff
2023-11-08 8:27 ` Morten Brørup
2023-11-08 13:40 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).