From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 8206C2B9D for ; Thu, 16 May 2019 10:59:44 +0200 (CEST) Received: by mail-wm1-f65.google.com with SMTP id y3so2735387wmm.2 for ; Thu, 16 May 2019 01:59:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=NWtvsLh4Enham5KDxaXUVYXclya5hktXIcvmano8mG0=; b=NpfvYOQ35tqlP8oYFg874jCnWb2ZAkBm0KtGJx99gFHdRGFm96DmdKI8IB0o/PGT9C 0nDWQQR/SquK8a5WZlD+QHde8b9z43ACcHscWpI+yGBvoGVENIylmYyO6YuS+AaHP4sh d9YojyUH9V4eRFuYf/9BaBTHXoS8MEYHNcCteXdn/0i77UVXhnkvfRm0UoVOqv0l8hEa Vn2Avg6bwkrnVqJ++zGwa0d8E1kcgh53PRo/Co0aVJnEuLnDfPh3zI792WXHdl7n8sx6 A1Znb77bvpeOd9g+ih37lxquXg6qapW2WrTdOS9sTdQPidtADlZ86eDfzxGArkTfkZoD bFdg== X-Gm-Message-State: APjAAAVGDoFRbm8japROMYEei0um/L1nGOl0HIhsw8klrcjPPHQF0qr7 md/RMIIzr/Ps1wlzk3sS92S1wyrE6YM= X-Google-Smtp-Source: APXvYqz7W/TFzzBkOnBq5qsDTw/TrsjvaQfzzkSDXSRcBf5hPYFl/qUbEATocLa7ngPP0fHmkfDQbQ== X-Received: by 2002:a7b:ce8c:: with SMTP id q12mr9794371wmj.33.1557997183969; Thu, 16 May 2019 01:59:43 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id 6sm6241507wrd.51.2019.05.16.01.59.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 May 2019 01:59:42 -0700 (PDT) Message-ID: <16a81a92627551d03e6c7620787468f0e77462fc.camel@debian.org> From: Luca Boccassi To: William Tu , dev@dpdk.org Date: Thu, 16 May 2019 09:59:42 +0100 In-Reply-To: <1557951879-123265-1-git-send-email-u9012063@gmail.com> References: <1557951879-123265-1-git-send-email-u9012063@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/af_xdp: add libelf for pmd_af_xdp. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 May 2019 08:59:44 -0000 On Wed, 2019-05-15 at 13:24 -0700, William Tu wrote: > The libbpf requires linking elf library. Fix it by > adding -lelf. >=20 > Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") > Signed-off-by: William Tu < > u9012063@gmail.com > > > --- > mk/rte.app.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/mk/rte.app.mk b/mk/rte.app.mk > index 7c9b4b538e52..e5d15218618a 100644 > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -145,7 +145,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL) +=3D > -lrte_mempool_dpaa2 > endif > =20 > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) +=3D -lrte_pmd_af_packet > -_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_XDP) +=3D -lrte_pmd_af_xdp > -lbpf > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_XDP) +=3D -lrte_pmd_af_xdp > -lbpf -lelf > _LDLIBS-$(CONFIG_RTE_LIBRTE_ARK_PMD) +=3D -lrte_pmd_ark > _LDLIBS-$(CONFIG_RTE_LIBRTE_ATLANTIC_PMD) +=3D -lrte_pmd_atlantic > _LDLIBS-$(CONFIG_RTE_LIBRTE_AVP_PMD) +=3D -lrte_pmd_avp Hi, This was already discussed, and libbpf needs to link with libelf itself as it's an internal dependency. It was already fixed in the kernel tree some time ago, so it should be correct with a recent version. If you are using an old version you can either update or fix it in your application. So I don't think we should carry this work-around ourselves in DPDK, as we'll end up overlinking when using fixed libbpf versions. --=20 Kind regards, Luca Boccassi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 30B22A00E6 for ; Thu, 16 May 2019 10:59:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 15C7E2BCE; Thu, 16 May 2019 10:59:46 +0200 (CEST) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 8206C2B9D for ; Thu, 16 May 2019 10:59:44 +0200 (CEST) Received: by mail-wm1-f65.google.com with SMTP id y3so2735387wmm.2 for ; Thu, 16 May 2019 01:59:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=NWtvsLh4Enham5KDxaXUVYXclya5hktXIcvmano8mG0=; b=NpfvYOQ35tqlP8oYFg874jCnWb2ZAkBm0KtGJx99gFHdRGFm96DmdKI8IB0o/PGT9C 0nDWQQR/SquK8a5WZlD+QHde8b9z43ACcHscWpI+yGBvoGVENIylmYyO6YuS+AaHP4sh d9YojyUH9V4eRFuYf/9BaBTHXoS8MEYHNcCteXdn/0i77UVXhnkvfRm0UoVOqv0l8hEa Vn2Avg6bwkrnVqJ++zGwa0d8E1kcgh53PRo/Co0aVJnEuLnDfPh3zI792WXHdl7n8sx6 A1Znb77bvpeOd9g+ih37lxquXg6qapW2WrTdOS9sTdQPidtADlZ86eDfzxGArkTfkZoD bFdg== X-Gm-Message-State: APjAAAVGDoFRbm8japROMYEei0um/L1nGOl0HIhsw8klrcjPPHQF0qr7 md/RMIIzr/Ps1wlzk3sS92S1wyrE6YM= X-Google-Smtp-Source: APXvYqz7W/TFzzBkOnBq5qsDTw/TrsjvaQfzzkSDXSRcBf5hPYFl/qUbEATocLa7ngPP0fHmkfDQbQ== X-Received: by 2002:a7b:ce8c:: with SMTP id q12mr9794371wmj.33.1557997183969; Thu, 16 May 2019 01:59:43 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id 6sm6241507wrd.51.2019.05.16.01.59.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 May 2019 01:59:42 -0700 (PDT) Message-ID: <16a81a92627551d03e6c7620787468f0e77462fc.camel@debian.org> From: Luca Boccassi To: William Tu , dev@dpdk.org Date: Thu, 16 May 2019 09:59:42 +0100 In-Reply-To: <1557951879-123265-1-git-send-email-u9012063@gmail.com> References: <1557951879-123265-1-git-send-email-u9012063@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/af_xdp: add libelf for pmd_af_xdp. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190516085942.JkvtWUS2wOBjpn-QVAiW6YmSTv8_g7roit8iDmw0myQ@z> On Wed, 2019-05-15 at 13:24 -0700, William Tu wrote: > The libbpf requires linking elf library. Fix it by > adding -lelf. >=20 > Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") > Signed-off-by: William Tu < > u9012063@gmail.com > > > --- > mk/rte.app.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/mk/rte.app.mk b/mk/rte.app.mk > index 7c9b4b538e52..e5d15218618a 100644 > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -145,7 +145,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL) +=3D > -lrte_mempool_dpaa2 > endif > =20 > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) +=3D -lrte_pmd_af_packet > -_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_XDP) +=3D -lrte_pmd_af_xdp > -lbpf > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_XDP) +=3D -lrte_pmd_af_xdp > -lbpf -lelf > _LDLIBS-$(CONFIG_RTE_LIBRTE_ARK_PMD) +=3D -lrte_pmd_ark > _LDLIBS-$(CONFIG_RTE_LIBRTE_ATLANTIC_PMD) +=3D -lrte_pmd_atlantic > _LDLIBS-$(CONFIG_RTE_LIBRTE_AVP_PMD) +=3D -lrte_pmd_avp Hi, This was already discussed, and libbpf needs to link with libelf itself as it's an internal dependency. It was already fixed in the kernel tree some time ago, so it should be correct with a recent version. If you are using an old version you can either update or fix it in your application. So I don't think we should carry this work-around ourselves in DPDK, as we'll end up overlinking when using fixed libbpf versions. --=20 Kind regards, Luca Boccassi