From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BDF66A0A02; Thu, 13 May 2021 15:10:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 79F174067E; Thu, 13 May 2021 15:10:36 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 7EEB34003F for ; Thu, 13 May 2021 15:10:34 +0200 (CEST) IronPort-SDR: +P7rWd8rJUU6eXuvUk59lMaUPNzPCcxIeeg2vDTZIo4MtDZl91w1P4hn3i+cuPZEGuM0hQxoKs JGuVz5Z15l1A== X-IronPort-AV: E=McAfee;i="6200,9189,9982"; a="263867636" X-IronPort-AV: E=Sophos;i="5.82,296,1613462400"; d="scan'208";a="263867636" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2021 06:10:07 -0700 IronPort-SDR: C+5QER/5uM/Kqiz9eJsYubqtGPt0OSMf/HNNB8Y+MAFAJ4t0Kx+rJVdvmlLXE/wNA86tzeIS9G oux/vTJzjoXw== X-IronPort-AV: E=Sophos;i="5.82,296,1613462400"; d="scan'208";a="431235082" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.242.51]) ([10.213.242.51]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2021 06:10:05 -0700 To: dev@dpdk.org, maxime.coquelin@redhat.com, david.marchand@redhat.com Cc: Thomas Monjalon , Chenbo Xia , Kevin Traynor References: <20210513122826.49910-1-chenbo.xia@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <16af9049-f7b5-f4f8-a6f8-6897e904591f@intel.com> Date: Thu, 13 May 2021 14:10:04 +0100 MIME-Version: 1.0 In-Reply-To: <20210513122826.49910-1-chenbo.xia@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] vhost: fix wrong IOTLB initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/13/2021 1:28 PM, Chenbo Xia wrote: > This patch fixes an issue of application crash because of vhost iotlb > not initialized when virtio has multiqueue enabled. > > iotlb messages will be sent when some queues are not enabled. If we > initialize iotlb in vhost_user_set_vring_num, it could happen that > iotlb update comes when iotlb pool of disabled queues are not > initialized. > > Fixes: 968bbc7e2e50 ("vhost: avoid IOTLB mempool allocation while IOMMU disabled") > > Signed-off-by: Chenbo Xia Hi Maxime, David, Can Red Hat QA verify this patch please? Btw, the issue is for defect: https://bugs.dpdk.org/show_bug.cgi?id=703