From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3DB0BA2EEB for <public@inbox.dpdk.org>; Fri, 13 Sep 2019 12:36:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1ED101F013; Fri, 13 Sep 2019 12:36:56 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 79EA61F00D for <dev@dpdk.org>; Fri, 13 Sep 2019 12:36:54 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 9609AB40055; Fri, 13 Sep 2019 10:36:51 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 13 Sep 2019 11:36:40 +0100 To: "Iremonger, Bernard" <bernard.iremonger@intel.com>, Neil Horman <nhorman@tuxdriver.com>, "Mcnamara, John" <john.mcnamara@intel.com>, "Kovacevic, Marko" <marko.kovacevic@intel.com>, Thomas Monjalon <thomas@monjalon.net>, "Yigit, Ferruh" <ferruh.yigit@intel.com> CC: "dev@dpdk.org" <dev@dpdk.org>, Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.com> References: <1566915962-5472-1-git-send-email-arybchenko@solarflare.com> <1568306586-27831-1-git-send-email-arybchenko@solarflare.com> <1568306586-27831-3-git-send-email-arybchenko@solarflare.com> <8CEF83825BEC744B83065625E567D7C260DF77A1@IRSMSX108.ger.corp.intel.com> From: Andrew Rybchenko <arybchenko@solarflare.com> Message-ID: <16be701c-2160-f630-19a7-c48a2a63e5d2@solarflare.com> Date: Fri, 13 Sep 2019 13:36:36 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <8CEF83825BEC744B83065625E567D7C260DF77A1@IRSMSX108.ger.corp.intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24908.002 X-TM-AS-Result: No-11.100600-8.000000-10 X-TMASE-MatchedRID: UuaOI1zLN1g4Q7K/HmUF53bspjK6JP6qJuDBbd4NSqQNWA0aQ3FdiCGU b2JNxi1qTWLw2jvbfpzTtVEL74Pv9RDyNU0hOxtbuwdUMMznEA+nHBIbyMjCFDbpMgyAfh26akC rXhKzdtmilC2NpSpl+yiRKIoWVVPgVa/qYn4n4ZacxB01DrjF9z8/nzP28gLZ33Nl3elSfsoZ6m TiEUoyEs6hawnxeOBBQ6PIUilISem2F9mW29B7ss0r+QpJcD1D3V4UShoTXafM/0sSqPZieC3ly 7H/QJvTNK82b4uddjmv0nQBLOKorZI5sqIgJvnA4h8r8l3l4eYO9z+P2gwiBYPLx3vY4vNiGq89 uArxpbcN0khrgbF6LJGTpe1iiCJq71zr0FZRMbAzOUjQ50/cs38DvkUabErVKrauXd3MZDU1qne tUPxv5ICCsjugkGEEpXntQSFCnaEtG8yGsUJe1pwW7/CiFc9VTNQCrdCRT1Oakj/BFxh2Idb7lT yTGqC1/cEwez4AJC3kQy7FBbY2sAbEQIfFpkwHBtlgFh29qnpKzBwu5JpklloKRXQm7FH3 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--11.100600-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24908.002 X-MDID: 1568371013-7h_ICq1LedLn Subject: Re: [dpdk-dev] [PATCH v4 02/54] ethdev: change rte_eth_dev_info_get() return value to int X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Hi Bernard, On 9/13/19 1:18 PM, Iremonger, Bernard wrote: > Hi Ivan, > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andrew Rybchenko >> Sent: Thursday, September 12, 2019 5:42 PM >> To: Neil Horman <nhorman@tuxdriver.com>; Mcnamara, John >> <john.mcnamara@intel.com>; Kovacevic, Marko >> <marko.kovacevic@intel.com>; Thomas Monjalon <thomas@monjalon.net>; >> Yigit, Ferruh <ferruh.yigit@intel.com> >> Cc: dev@dpdk.org; Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.com> >> Subject: [dpdk-dev] [PATCH v4 02/54] ethdev: change >> rte_eth_dev_info_get() return value to int >> >> From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.com> >> >> Change rte_eth_dev_info_get() return value from void to int and return >> negative errno values in case of error conditions. >> Modify rte_eth_dev_info_get() usage across the ethdev according to new >> return type. >> >> Signed-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.com> >> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com> >> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> > ./check-git-log.sh -1 > Wrong headline format: > ethdev: change rte_eth_dev_info_get() return value to int In this particular case we decided (may be incorrectly) that it would be more harm if we rephrase it without mentioning function name. It is trivial to fix. No strong opinion. My main goal of yesterday re-spin was to check build with missing patch applied to DPDK main repo, but unfortunately there are still some build issues (meson column) which I don't understand. Andrew.