Re: [dpdk-dev] [dpdk-stable] 17.11.7-rc1 (LTS) patches review and test

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 8/30/2019 9:42 AM, Wang, FengqinX wrote:
> Hi Ferruh,
> 
> After verify, this fixes works fine after we merge it to stable 17.11.7.

Thanks for verifying this.

> BTW, do we have plan to apply this patch to the stable 17.11.7?

It is a task for 17.11 LTS maintainer, who we don't know yet.

> 
> BRs, Vicky
> 
> -----Original Message-----
> From: Yigit, Ferruh 
> Sent: Friday, August 30, 2019 12:11 AM
> To: Yongseok Koh <yskoh@mellanox.com>; dpdk stable <stable@dpdk.org>
> Cc: dev@dpdk.org; pezhang@redhat.com; siliu@redhat.com; Wang, FengqinX <fengqinx.wang@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>; Xu, Qian Q <qian.q.xu@intel.com>; alialnu@mellanox.com; rasland@mellanox.com
> Subject: Re: [dpdk-stable] 17.11.7-rc1 (LTS) patches review and test
> 
> On 8/15/2019 7:05 PM, Yongseok Koh wrote:
>> Hi all,
>>
>> Here is a list of patches targeted for LTS release 17.11.7. Please 
>> help review and test. The planned date for the final release is Aug 
>> 23, Before that, please shout if anyone has objections with these patches being applied.
>>
>> Also for the companies committed to running regression tests, please 
>> run the tests and report any issue before the release date.
>>
>> A release candidate tarball can be found at:
>>
>>     https://dpdk.org/browse/dpdk-stable/tag/?id=v17.11.7-rc1
>>
>> These patches are located at branch 17.11 of dpdk-stable repo:
>>     https://dpdk.org/browse/dpdk-stable/
> 
> 
> I am getting build error [1] with Fedora 30 and gcc [2], the issue seems fixed in the main repo [3].
> 
> 
> 
> [1] [-Werror=address-of-packed-member]
> 
> .../lib/librte_eal/common/eal_common_tailqs.c: In function ‘rte_eal_tailq_lookup’:
> .../lib/librte_eal/common/eal_common_tailqs.c:76:11: error: taking address of packed member of ‘struct rte_mem_config’ may result in an unaligned pointer value [-Werror=address-of-packed-member]
>    76 |    return &mcfg->tailq_head[i];
>       |           ^~~~~~~~~~~~~~~~~~~~
> .../lib/librte_eal/common/eal_common_tailqs.c: In function ‘rte_dump_tailq’:
> .../lib/librte_eal/common/eal_common_tailqs.c:90:23: error: taking address of packed member of ‘struct rte_mem_config’ may result in an unaligned pointer value [-Werror=address-of-packed-member]
>    90 |  rte_rwlock_read_lock(&mcfg->qlock);
>       |                       ^~~~~~~~~~~~
> .../lib/librte_eal/common/eal_common_tailqs.c:92:40: error: taking address of packed member of ‘struct rte_mem_config’ may result in an unaligned pointer value [-Werror=address-of-packed-member]
>    92 |   const struct rte_tailq_head *tailq = &mcfg->tailq_head[i];
>       |                                        ^~~~~~~~~~~~~~~~~~~~
> .../lib/librte_eal/common/eal_common_tailqs.c:98:25: error: taking address of packed member of ‘struct rte_mem_config’ may result in an unaligned pointer value [-Werror=address-of-packed-member]
>    98 |  rte_rwlock_read_unlock(&mcfg->qlock);
>       |                         ^~~~~~~~~~~~
> .../lib/librte_eal/common/eal_common_tailqs.c: In function ‘rte_eal_tailq_create’:
> .../lib/librte_eal/common/eal_common_tailqs.c:111:10: error: taking address of packed member of ‘struct rte_mem_config’ may result in an unaligned pointer value [-Werror=address-of-packed-member]
>   111 |   head = &mcfg->tailq_head[rte_tailqs_count];
>       |
> 
> [2]
> $ lsb_release -a
> LSB Version:    :core-4.1-amd64:core-4.1-noarch
> Distributor ID: Fedora
> Description:    Fedora release 30 (Thirty)
> Release:        30
> Codename:       Thirty
> 
> $ gcc --version
> gcc (GCC) 9.1.1 20190503 (Red Hat 9.1.1-1)
> 
> 
> [3]
> Fixes: a385972c3675 ("mk: disable warning for packed member pointer")
>