From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C36745B08; Thu, 10 Oct 2024 19:02:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C55240656; Thu, 10 Oct 2024 19:02:01 +0200 (CEST) Received: from fhigh-a8-smtp.messagingengine.com (fhigh-a8-smtp.messagingengine.com [103.168.172.159]) by mails.dpdk.org (Postfix) with ESMTP id 89665402A3 for <dev@dpdk.org>; Thu, 10 Oct 2024 19:01:59 +0200 (CEST) Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfhigh.phl.internal (Postfix) with ESMTP id 30B16114018A; Thu, 10 Oct 2024 13:01:59 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-10.internal (MEProxy); Thu, 10 Oct 2024 13:01:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1728579719; x=1728666119; bh=WGB4khwXfe81P3wK54AAkZegpKtYoP172JJq5456cHk=; b= Z7nCNCRnNfc/NODkPZp5Pz4f6YSWX1l7izltxn6ksRQMJA8dWMZ272zAWv6XGuqT qEVC0xaftHLyRDz1XCjRkMTNj7q1sVBpcD9rUY9kzoSQ7nHOjI1glnwlUUMzsiuu fdiA2oQGOhiKHLe0bOHD3yxtqRmr8zXpkE5/4b0gIUODhjI7AhZtejgwPtwJjydO y7a14K8ht5x5ZS7EZw2RN9ZCWzlCe8jlP1SBVDnPYjlnR0Xf4iX1pImL1ifrv2O/ HPNHfpm798XfTfIO0Kde2jJbelenWNsq/nUuefo4LUm0PYJAz1soSH+vyDFCLMiF 8zVRieBHTImaysTbse+R6w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1728579719; x= 1728666119; bh=WGB4khwXfe81P3wK54AAkZegpKtYoP172JJq5456cHk=; b=K 9IOhVYUIG1dIvLn2tKdT+e/XjHQPKgmRi2G4V27ET2KjboqXoycDmHZib1BhBP6t bBR7Extj8MK7lcD+zk/dtc6j8LA4cCnJUmVD4VhdLl2fvBfC3/zOwzhxGXh8ml7H b0INGHuT3xZaZ2XLL8DNpR9zZM77QfBtB+JSwhTjRAXPJisktWoGI8AewkvMgd2+ Muup25xm9XgaFdQq+iawnmzrpq3iKsP6BicIXl3Uvv5b0vOxq5hnwASFmjT1dAYZ WG4EjWqQJnE6hK3nBBjqgQlHtcm3kE/EWMi0ZZ7CGiqlGNXV79aydLr8B/cwa8/S se4/V3o4on81VL/ckGkwA== X-ME-Sender: <xms:hggIZyTzE6kaH-1ec4xnbq-5Hv7iN5dd_4kFMgRxdptu55qsSRDzmw> <xme:hggIZ3z6Fo833YH90XfTvmB5GA06hkIgJ1--K47X7OmBvaWHhuTE8yv2XThIlhoYc K0i3eRgxdLFTb9Ibw> X-ME-Received: <xmr:hggIZ_1mhPuT_lE5GsosdlJq1f_qUcN0lJEoFli8lxkr4AkUAIF84xClaGtvjfbija59umzc-CRlJka-AlzybBbf5w> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdefhedgudduudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdej necuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjh grlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdeg keeuveejffejgedtgeegkefgvdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthdp nhgspghrtghpthhtohepuddtpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopeifrg hthhhsrghlrgdrvhhithhhrghnrghgvgesrghrmhdrtghomhdprhgtphhtthhopehrohhr vghtiihlrgeslhhinhhugidrmhhitghrohhsohhfthdrtghomhdprhgtphhtthhopehruh hifhgvnhhgrdifrghnghesrghrmhdrtghomhdprhgtphhtthhopehhohhnnhgrphhprgdr nhgrghgrrhgrhhgrlhhlihesrghrmhdrtghomhdprhgtphhtthhopeguvghvseguphgukh drohhrghdprhgtphhtthhopeguhhhruhhvrdhtrhhiphgrthhhihesrghrmhdrtghomhdp rhgtphhtthhopehjrggtkhdrsghonhguqdhprhgvshhtohhnsehfohhsshdrrghrmhdrtg homhdprhgtphhtthhopehnihgtkhdrtghonhhnohhllhihsegrrhhmrdgtohhmpdhrtghp thhtohepvhhinhhougdrkhhrihhshhhnrgesrghrmhdrtghomh X-ME-Proxy: <xmx:hggIZ-CTBqgkVlOeNTJoYxGl-YKpihsBon5mwkZuI79gopZuEjEGxg> <xmx:hggIZ7j6a0KHE0QHTWvgVaWm75G5LoQ4b8eqp-f6ICVrxnMxB-dj8g> <xmx:hggIZ6qswX2utN0PqEypWm2OGQ8XwFW3X65ZUYg9C0pHaIQ1D5AAOA> <xmx:hggIZ-jR7JfsdJlu73c0iBroCGRn6NZ_QT32Pl0W7YQjjZ5KlUHf8g> <xmx:hwgIZwarJuGhyJd1yduQtvdO-YFKOMjGctoDIVlYoeJwMvqFvs_nwkvk> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 10 Oct 2024 13:01:57 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Wathsala Vithanage <wathsala.vithanage@arm.com> Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>, Ruifeng Wang <ruifeng.wang@arm.com>, honnappa.nagarahalli@arm.com, dev@dpdk.org, Wathsala Vithanage <wathsala.vithanage@arm.com>, Dhruv Tripathi <dhruv.tripathi@arm.com>, Jack Bond-Preston <jack.bond-preston@foss.arm.com>, Nick Connolly <nick.connolly@arm.com>, Vinod Krishna <vinod.krishna@arm.com> Subject: Re: [PATCH v4 3/4] eal: add Arm WFET in power management intrinsics Date: Thu, 10 Oct 2024 19:01:55 +0200 Message-ID: <17015934.geO5KgaWL5@thomas> In-Reply-To: <20240726171528.2245682-3-wathsala.vithanage@arm.com> References: <20240604044401.3577707-1-wathsala.vithanage@arm.com> <20240726171528.2245682-1-wathsala.vithanage@arm.com> <20240726171528.2245682-3-wathsala.vithanage@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 26/07/2024 19:15, Wathsala Vithanage: > Wait for event with timeout (WFET) puts the CPU in a low power > mode and stays there until an event is signalled (SEV), loss of > an exclusive monitor or a timeout. > WFET is enabled selectively by checking FEAT_WFxT in Linux > auxiliary vector. If FEAT_WFxT is not available power management > will fallback to WFE. > WFE is available on all the Arm platforms supported by DPDK. > Therefore, the RTE_ARM_USE_WFE macro is not required to enable > the WFE feature for PMD power monitoring. > RTE_ARM_USE_WFE is used at the build time to use the WFE instruction > where applicable in the code at the developer's discretion rather > than as an indicator of the instruction's availability. > > Signed-off-by: Wathsala Vithanage <wathsala.vithanage@arm.com> > Reviewed-by: Dhruv Tripathi <dhruv.tripathi@arm.com> > Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> > Reviewed-by: Jack Bond-Preston <jack.bond-preston@foss.arm.com> > Reviewed-by: Nick Connolly <nick.connolly@arm.com> > Reviewed-by: Vinod Krishna <vinod.krishna@arm.com> Series applied, thanks.