From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 85FDC1150; Thu, 17 Jan 2019 21:24:05 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 5577314BD; Thu, 17 Jan 2019 15:24:04 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 17 Jan 2019 15:24:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=1uJOskzjqc6F2ni5LH+ivNFeyDaQ7RSil8WiEtBzS9s=; b=PXaIrh3yQEWF crZ3orgGfVdTepgqYOb3IEXDzEK/aKAzEGhJaFyH0x0zxlmxCzzhBhkQYsjJSxoS i3pO2WG2M/8xFL/F8JslUfDVUErm4dxmJX4rRhXkyXCTe202bZjCT4hGC0hQv5ZP tj0DJXVozed/bkU9n0GfgWvxuCytSIw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=1uJOskzjqc6F2ni5LH+ivNFeyDaQ7RSil8WiEtBzS 9s=; b=Ht3H02J71E12ZHxE5j71Bgc3k71UbWEGKIXLOQaBIGddAzMwKu1imWGuz 9p0D9+C6QMCnGWAc0gycScfXc2lSy8chDv1lN3o7uIpbFMbLwuF+XqsZL+G+rYDG qgqkPEj3tce2QXnU0GCdrc35H2zyo6BjVTZYQElDN3tiJqHVcCXnA/BIhp6sn6iP HUv7ngPggTylT+iG1KRN1ofTI1pKUztpdDbppSkbjtto8e7TuoarVPrga4eIpSIQ wbCgCWJOlWDg95BvTEfPZwP0O89w0YTs5rjGc/5f2OPuWa+IkYgqiYe4AXZ+htQ8 AD/TleloMu662S0ldb6cTid9QsnZw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrgeekgddufeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg hfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3FAA7E455C; Thu, 17 Jan 2019 15:24:02 -0500 (EST) From: Thomas Monjalon To: "Pattan, Reshma" Cc: dev@dpdk.org, "stable@dpdk.org" , "Yigit, Ferruh" Date: Thu, 17 Jan 2019 21:23:59 +0100 Message-ID: <17017098.YGx1iN1oWD@xps> In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A400A38@irsmsx110.ger.corp.intel.com> References: <20190111174134.39772-1-reshma.pattan@intel.com> <1859916.dnCeAC13tB@xps> <3AEA2BF9852C6F48A459DA490692831F2A400A38@irsmsx110.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] pdump: fix vdev cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 20:24:05 -0000 15/01/2019 11:25, Pattan, Reshma: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 15/01/2019 11:09, Pattan, Reshma: > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > 11/01/2019 18:51, Reshma Pattan: > > > > > Virtual devices added in pdump application using > > > > > rte_eal_hotplug_add should be removed explicitly while existing > > > > > the pdump application, otherwise the > > > > > > > > existing -> exiting ? > > > > > > > > > subsequent run of the pdump application will fail with the reason > > > > > that virtual devices with the same name already exists in primary. > > > > > > > > > > Fixes: 6362f362a2 ("app/pdump: use EAL hotplug instead of ethdev > > > > > attach") > > > > > CC: stable@dpdk.org > > > > > CC: ferruh.yigit@intel.com > > > > > > > > Why is it marked as a fix of this commit? > > > > Is it a miss in the conversion from ethdev attach calls? > > > > Or a changed behaviour with hotplug functions? > > > > > > It is changed behaviour with hotplug functions. > > > > Please, could you explain? > > > > Attach calls were replaced with rte_eal_hotplug_remove() in pdump in the commit id given in Fixes line. > > And after this change, the subsequent runs(other than 1st) of pdump application are failing with below error > > 1)Pdump application error: > > EAL: Failed to hotplug add device > EAL: Error - exiting with code: 1 > Cause: vdev creation failed:create_mp_ring_vdev:706 > > 2)And error on primary application side is below: > testpmd> Ethernet device with name net_pcap_rx_0 already allocated > EAL: Failed to hotplug add device on primary > > So, the dev added in secondary should be removed during its exit by calling rte_eal_hotplug_remove (). > > So, that is the reason I chose the Fixes: commit as the one where rte_eal_hotplug_add() replaced the attach. > > Earlier with attach calls though not detaching the devices upon application exit, these issues are not seen. OK I won't dig to understand why this error was hidden with previous API. I'll assume there is no need to backport this fix in 17.11.