From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f182.google.com (mail-wj0-f182.google.com [209.85.210.182]) by dpdk.org (Postfix) with ESMTP id 245141E27 for ; Fri, 16 Dec 2016 19:09:04 +0100 (CET) Received: by mail-wj0-f182.google.com with SMTP id xy5so97318243wjc.0 for ; Fri, 16 Dec 2016 10:09:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=lg4g33iyjDmu0Ox781KKZ6UQ/u+c6D+DqzMeyIX7HGA=; b=BXNSo2zOwSYayJsdssq6h/kcKAT8pMU93u7TSHBrr8xLNeYyWAJTHQ1xkQ5NEKraGh VldEnfVJBFUlG3PO1AV63knNIgapFq/HjPyGREFxy+7Npik8h4p71Jt4MxdGwj22NTvB vle25xTOLVmYDObT3hOaA+kV7MIVOvxJUQHN6s8ypKgznIbN6vVzQRLRi/biyUrqI6Pv lTZb94wToA2F6e7JRJo8FdPdV7mr6Ix7X5+8Oks9Ioh0jYZKDe+wzztTw60eLTqSdLbo OuVlved7nep7m5YhRJ6SC+eWahXozPMHWR7EN+F3JfJgQ6s2JDrhpFZ8IKxlucn530dq qDCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=lg4g33iyjDmu0Ox781KKZ6UQ/u+c6D+DqzMeyIX7HGA=; b=ezqGdB4c+dhBAN0cbzQ/37SMxMM7o96yjZDUDpoeyAdKTbVVZc743MNidi1tWYoOSR uGCJi3H29r7Xd0Nng0wjVYIC1RFXK6foOhhTwxLB2619l2ZsWz8NTcXBFSCG0cZhWHaH UbMYfxnJkcKb9EJc8845Sp8NDmeaLcpvg9IMUpQ3ReX/xruJ1SmPQ9PnR3jaBuM4lWn0 XatPHdXkV1AxwpJwzjUYyi5oVESnlCrKl5FPbQzvCJlFS4gAWpJ827Tv0Ef9BjWptYdL ZhgXuPkX4Wm3QMJWXk6W6EM3cemhWq63ydz8349DNZMoBCIQIqYCoLcQZ16jaQJBQqqS tKCQ== X-Gm-Message-State: AIkVDXJNS213H43LzsBGJM0VuHzTpXEeJDqaV6TJ4Td1AUtmnwAev7rlP8Kj8959anLE2aKe X-Received: by 10.195.18.201 with SMTP id go9mr3971162wjd.200.1481911743789; Fri, 16 Dec 2016 10:09:03 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id i132sm4383794wmf.14.2016.12.16.10.09.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Dec 2016 10:09:02 -0800 (PST) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, Shreyansh Jain , Stephen Hemminger Date: Fri, 16 Dec 2016 19:09:02 +0100 Message-ID: <17034171.EHDWhStFHz@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20161215092631.5cb798b2@xeon-e3> References: <20161214235920.12877-1-sthemmin@microsoft.com> <544b6faf-11f4-93fe-6427-7d3fcfaba388@nxp.com> <20161215092631.5cb798b2@xeon-e3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/2] hyperv: VMBUS support infrastucture X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Dec 2016 18:09:04 -0000 2016-12-15 09:26, Stephen Hemminger: > On Thu, 15 Dec 2016 12:19:44 +0530 > Shreyansh Jain wrote: > > It is not a scale-able model where we have to change eth_driver/eth_dev > > for every new device type, other than PCI. Maybe VMBus is _very_ close > > to PCI so no changes are required in PCI layer (common, linuxapp, > > bsdapp) - but, for others it won't stop there. > > > > At the least, rte_pci_driver/rte_pci_device should be removed from > > eth_driver & rte_eth_dev, respectively - relying on rte_driver and > > rte_device. > > > > This is the primary reason work on the SoC patchset and now the new Bus > > model is being done. > > Agreed. the better long term model is to use C style inheritance where > rte_pci_driver has eth_driver inside. > The other alternative is to make the second element an opaque pointer. > > But that was too big a change, and not necessary to get VMBUS to work. > Longer term refactoring will take more effort. Go ahead and address it > with a better bus model, but that probably isn't going to be ready for > a couple of releases. We'll consider only the approach of generalizing the bus model for integr ation. Stephen, you are welcome to help make it happen and rebase your work on top of this new model. Thanks