From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 215635587 for ; Mon, 17 Dec 2018 21:35:27 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A7E75218EB; Mon, 17 Dec 2018 15:35:25 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 17 Dec 2018 15:35:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=IBiawUptmWnIBSdbhdMk3mfe/xkPQ8lNKid6NILyCAI=; b=DGE1P9Hmpxm/ Ee0uIRVK8B9iYesjNusgpUd1FrjHu4VBjGzVH/q1fawwj2t8U0+G/eeYXDa1nnQp w2vf9sVb+U5WuGAVUCtgEbTkx+J4+i/KDYBDB43oRXgq/1Y647hDQHTfR8fTAB3C PwCdXywj7yhcSAO1V+1nXuINZGlXytI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=IBiawUptmWnIBSdbhdMk3mfe/xkPQ8lNKid6NILyC AI=; b=G6h1FTVkF0a3296Mw5+i9/GjBQEsGuoh42+Fc4CoWCrALRXON0gA5ignE t+HclkyQPIJwtQaIt61WKERtF7hT6fPNDtHb35BxpPeQ7BTkzxXaLsVTVMJlOMHT XqhlxJtc8tIGBLjw9M6XLzMrHlqikwsuymIPECALtfSc8YuqczbaWQaliPubzaf0 pP4IJlGmmnbWdWgTH0P+lkspYH//OLt6IZPyP7YkXu0AFtegOhLO7l/WN9xQPvQq Uj8bca1YZZS6ZuwEbiEn38Ohq7e3jUAP0CEbPThCO1crPLEUnaMMWwDYtzWHVjgo Vn2nzXH3N233Ry7dTki8MsKC7Gbfw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudeifedggeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg hfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 05951E4663; Mon, 17 Dec 2018 15:35:23 -0500 (EST) From: Thomas Monjalon To: Reshma Pattan Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, nikhil.rao@intel.com, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, ferruh.yigit@intel.com, arybchenko@solarflare.com Date: Mon, 17 Dec 2018 21:35:19 +0100 Message-ID: <1704422.YVeuKdbJKR@xps> In-Reply-To: <20181213180851.4862-1-reshma.pattan@intel.com> References: <1544193116-7058-1-git-send-email-reshma.pattan@intel.com> <20181213180851.4862-1-reshma.pattan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/2] eal: add new rte color definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2018 20:35:27 -0000 13/12/2018 19:08, Reshma Pattan: > Added new rte_color definition in eal to > consolidate color definition which is currently replicated > in various places such as rte_meter.h, rte_tm.h and rte_mtr.h I don't think EAL is the right place for such definition. Why ethdev would not rely on definitions from rte_meter.h?