From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 189EE5B38
for <dev@dpdk.org>; Wed, 27 Mar 2019 10:52:42 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id AF91B21D0A;
Wed, 27 Mar 2019 05:52:41 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute1.internal (MEProxy); Wed, 27 Mar 2019 05:52:41 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=mesmtp;
bh=R+jHNM0KM+go5scz1inyPAO+PMBeGWUGNGHDXbTAb3Q=; b=LhvCXFepOFwB
y2Mtrn4Kz5GV2YSwnbQo0gAjHJLPy6xPOT+N9TP3m3JIJ7r+gwrvTZ0DWzPP40ro
c7PHtwScWZcKhZnZl2eVVlz9WP/DeQ9g+9Jnv/3/RM9QoF7HrlKWpiLUqc1EIto7
oSUh2u7fbzpOe2jfbLX23Au3q+jko+s=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=R+jHNM0KM+go5scz1inyPAO+PMBeGWUGNGHDXbTAb
3Q=; b=AtXNSvycUHRp4OszLBKkt7rQ4jQJ94Bpd0q04C8VfZPkQK6g2cC9eF3xF
8X/lC2b6DzoBg2CtkV83MJm7XlP83F14Zv1KNF7zFxLFQpddzrAryVHKEnzVrF20
+Ku0LsQRr0N5mWAl9uucLkjX5zrBeZD9aZXNYN8sDyH5cgSDm9lVywKAAbPaA7Ga
XEjtYhoqQK3BBTA2An63fPl13/W2kk1iysCwZS6w+/ipRXwIVQ+aY+d1Kllb9+8O
iCrTa36HtKPJKUgK4mbcBj/YVECeU+cUOB6p/RvillgSDZjEQYDyVI7kg2LPJYMG
t+hqhwaEbD2mwkPKxMz6lApc8uQ9g==
X-ME-Sender: <xms:6UebXBUpVcBmDKbc9JTszOrjyWWH5vyNLzyzZ3VECJogfS2M1HN-7Q>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkedvgddtiecutefuodetggdotefrodftvf
curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
fjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghs
ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph
epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho
mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:6UebXNeqiliXqztiNXND5A7kQKGRewu0Rxc65tvrFSb4dmoSTvKa0w>
<xmx:6UebXI7Oz0GGal1FLtOBbN2LV3rWOzA2Is-KVnJB1wgKDLp8fYUMHw>
<xmx:6UebXIRwaZvtrxh7Ikwcu9jLsBE-L0TPzj_6-vjNK-3IDTFEOwqhLA>
<xmx:6UebXLkMcRihvyb07iEQWPDAjcxKrahTsnhIynAy7aXLqtzI94DDAw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 43E0A10310;
Wed, 27 Mar 2019 05:52:40 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Nikhil Rao <nikhil.rao@intel.com>
Cc: dev@dpdk.org, harry.van.haaren@intel.com, ferruh.yigit@intel.com
Date: Wed, 27 Mar 2019 10:52:39 +0100
Message-ID: <1705677.IYcAMfH6DV@xps>
In-Reply-To: <1550226554-147562-1-git-send-email-nikhil.rao@intel.com>
References: <1547906489-71240-1-git-send-email-nikhil.rao@intel.com>
<1550226554-147562-1-git-send-email-nikhil.rao@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v3] service: fix parameter type
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Mar 2019 09:52:42 -0000
15/02/2019 11:29, Nikhil Rao:
> The type of value parameter to rte_service_attr_get
> should be uint64_t *, since the attributes
> are of type uint64_t.
>=20
> Fixes: 4d55194d76a4 ("service: add attribute get function")
>=20
> Reviewed-by: Gage Eads <gage.eads@intel.com>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
> ---
> --- a/lib/librte_eal/common/include/rte_service.h
> +++ b/lib/librte_eal/common/include/rte_service.h
> int32_t rte_service_attr_get(uint32_t id, uint32_t attr_id,
> - uint32_t *attr_value);
> + uint64_t *attr_value);
I'm seeing this error:
app/test/test_service_cores.c:265:8: error:
passing argument 3 of =E2=80=98rte_service_attr_get=E2=80=99 from incompati=
ble pointer type
> --- a/doc/guides/rel_notes/release_19_05.rst
> +++ b/doc/guides/rel_notes/release_19_05.rst
> - librte_eal.so.9
> + +librte_eal.so.10
A space is missing after the +
From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id D633DA05D3
for <public@inbox.dpdk.org>; Wed, 27 Mar 2019 10:52:43 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 955F05F13;
Wed, 27 Mar 2019 10:52:43 +0100 (CET)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 189EE5B38
for <dev@dpdk.org>; Wed, 27 Mar 2019 10:52:42 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id AF91B21D0A;
Wed, 27 Mar 2019 05:52:41 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute1.internal (MEProxy); Wed, 27 Mar 2019 05:52:41 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=mesmtp;
bh=R+jHNM0KM+go5scz1inyPAO+PMBeGWUGNGHDXbTAb3Q=; b=LhvCXFepOFwB
y2Mtrn4Kz5GV2YSwnbQo0gAjHJLPy6xPOT+N9TP3m3JIJ7r+gwrvTZ0DWzPP40ro
c7PHtwScWZcKhZnZl2eVVlz9WP/DeQ9g+9Jnv/3/RM9QoF7HrlKWpiLUqc1EIto7
oSUh2u7fbzpOe2jfbLX23Au3q+jko+s=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=R+jHNM0KM+go5scz1inyPAO+PMBeGWUGNGHDXbTAb
3Q=; b=AtXNSvycUHRp4OszLBKkt7rQ4jQJ94Bpd0q04C8VfZPkQK6g2cC9eF3xF
8X/lC2b6DzoBg2CtkV83MJm7XlP83F14Zv1KNF7zFxLFQpddzrAryVHKEnzVrF20
+Ku0LsQRr0N5mWAl9uucLkjX5zrBeZD9aZXNYN8sDyH5cgSDm9lVywKAAbPaA7Ga
XEjtYhoqQK3BBTA2An63fPl13/W2kk1iysCwZS6w+/ipRXwIVQ+aY+d1Kllb9+8O
iCrTa36HtKPJKUgK4mbcBj/YVECeU+cUOB6p/RvillgSDZjEQYDyVI7kg2LPJYMG
t+hqhwaEbD2mwkPKxMz6lApc8uQ9g==
X-ME-Sender: <xms:6UebXBUpVcBmDKbc9JTszOrjyWWH5vyNLzyzZ3VECJogfS2M1HN-7Q>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkedvgddtiecutefuodetggdotefrodftvf
curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
fjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghs
ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph
epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho
mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:6UebXNeqiliXqztiNXND5A7kQKGRewu0Rxc65tvrFSb4dmoSTvKa0w>
<xmx:6UebXI7Oz0GGal1FLtOBbN2LV3rWOzA2Is-KVnJB1wgKDLp8fYUMHw>
<xmx:6UebXIRwaZvtrxh7Ikwcu9jLsBE-L0TPzj_6-vjNK-3IDTFEOwqhLA>
<xmx:6UebXLkMcRihvyb07iEQWPDAjcxKrahTsnhIynAy7aXLqtzI94DDAw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 43E0A10310;
Wed, 27 Mar 2019 05:52:40 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Nikhil Rao <nikhil.rao@intel.com>
Cc: dev@dpdk.org, harry.van.haaren@intel.com, ferruh.yigit@intel.com
Date: Wed, 27 Mar 2019 10:52:39 +0100
Message-ID: <1705677.IYcAMfH6DV@xps>
In-Reply-To: <1550226554-147562-1-git-send-email-nikhil.rao@intel.com>
References: <1547906489-71240-1-git-send-email-nikhil.rao@intel.com>
<1550226554-147562-1-git-send-email-nikhil.rao@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v3] service: fix parameter type
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190327095239.2v2Zl-3y2pb0cArJ6KOzaeaGONrL5ynm8dl3HvPMdQI@z>
15/02/2019 11:29, Nikhil Rao:
> The type of value parameter to rte_service_attr_get
> should be uint64_t *, since the attributes
> are of type uint64_t.
>=20
> Fixes: 4d55194d76a4 ("service: add attribute get function")
>=20
> Reviewed-by: Gage Eads <gage.eads@intel.com>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
> ---
> --- a/lib/librte_eal/common/include/rte_service.h
> +++ b/lib/librte_eal/common/include/rte_service.h
> int32_t rte_service_attr_get(uint32_t id, uint32_t attr_id,
> - uint32_t *attr_value);
> + uint64_t *attr_value);
I'm seeing this error:
app/test/test_service_cores.c:265:8: error:
passing argument 3 of =E2=80=98rte_service_attr_get=E2=80=99 from incompati=
ble pointer type
> --- a/doc/guides/rel_notes/release_19_05.rst
> +++ b/doc/guides/rel_notes/release_19_05.rst
> - librte_eal.so.9
> + +librte_eal.so.10
A space is missing after the +