From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 59015A0524;
Tue, 20 Apr 2021 11:37:07 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 388F34169C;
Tue, 20 Apr 2021 11:37:07 +0200 (CEST)
Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com
[64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 77680411A5
for <dev@dpdk.org>; Tue, 20 Apr 2021 11:37:06 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.west.internal (Postfix) with ESMTP id 20A701E4D;
Tue, 20 Apr 2021 05:37:04 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute1.internal (MEProxy); Tue, 20 Apr 2021 05:37:04 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm1; bh=
Kse5CTct3vtLpmr8agYktuO7Cd2lONtiIfy9C0WQKsU=; b=PxS6s6qSs06KYXQU
NE6RQZQ/hMuXZSVYEmiyNcwHf2+cJ7/Gx2ZDXmATtBpR2oLIaHnfMFd0QB6Pibyn
6AavZg5ev1yv2HtVcMW3APaLjOXUWEKqDvRa0hz46K5FSaE5psSORzATInOOngzW
QOBeLo4Uf8ZuSxJSgcNANvzLxysC71ONRLH8PZNVox6nteL8khba8202tPBMHynt
RF6M23+cJCgb0OgS6MtuFeCWJvTUMA+uiDBI3AOJ9ECRQDxDJvKbihXnGo9zYgOn
Qr0jnU2lgkY+2rSqUYEKr1q+pzuYao1mjde6306gVfinA7Zh6fFiQKMBDPeEK4vR
PEUc5Q==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=Kse5CTct3vtLpmr8agYktuO7Cd2lONtiIfy9C0WQK
sU=; b=ctZPTZnnHygv0WC/M7ytIm+EjH+OK/c/lSpBQu2m0RAMuDOQNo/D6FhFh
i37TXfCKDS0VjsmcsPc7JPASKsVew/M3WNLLLIuB685myo4G7C6AhUkYrp4i/+lM
eieAe60qNeB7cgLP/6J/c/IOi/OSDFMutl/DnYJqTZFWi3j3s2iycu5HFeNgvZUI
BpFKHtfo3ua/gLqYdwJ+ygMHId2VhP8ZQZ/1xvSnb6l/xOXJ8IHOdTV2An1Lpq9o
YrUZlS041v1nYqN+PJCSdUL5uZXndoCxY15/lo8naF61clCc8iU0W9/zoDjbWMPo
E6MHwa4ngVKs5wxe25k7Zv5xgW0ZA==
X-ME-Sender: <xms:v6B-YAZ5YGGIWRy76XBt40Fxf-aab3zZ4g5b4MAMOztN-X7dKMxtSQ>
<xme:v6B-YLVszFDq4zPFXDbOmkSkfCCLnGe1srXunNcRM2u-MJVHsTf8Ydz5zg2ZKdNqL
IA-XU-iVpVwwi3C5w>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddtiedgudekucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
ftrfgrthhtvghrnhepkeethedtieevhfeigeejleegudefjeehkeekteeuveeiuedvveeu
tdejveehveetnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
ohhnrdhnvght
X-ME-Proxy: <xmx:v6B-YH3ctd4W8QTlxzRXk79Fv81QboyI0C7F4HI4VS0PnXpnu82PdQ>
<xmx:v6B-YCYcbqKe3DyjSkUoVBgo3ErEwMnVkek8UVx-xN8xW4tV3DRAaQ>
<xmx:v6B-YKopMwz6fNeav12qiU3OsPRDfMZrnMKMtjiL_RmMlXiB25vIYw>
<xmx:v6B-YKFs04YC_eH8BZpamRPmsAGpiQrYEW7pkEefrKzmtGQxAJqEKQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 941B81080064;
Tue, 20 Apr 2021 05:37:02 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Chengwen Feng <fengchengwen@huawei.com>,
"Min Hu (Connor)" <humin29@huawei.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com
Date: Tue, 20 Apr 2021 11:37:00 +0200
Message-ID: <1706834.A6OOkbCCPt@thomas>
In-Reply-To: <f8bdb513-5959-d4e0-9643-99813b9d9b15@huawei.com>
References: <1617876888-63458-1-git-send-email-humin29@huawei.com>
<2544130.Cegyj9CWiX@thomas> <f8bdb513-5959-d4e0-9643-99813b9d9b15@huawei.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH 1/2] examples/ethtool: fix Rx/Tx queue setup
with rte socket id
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
20/04/2021 11:05, Min Hu (Connor):
> =E5=9C=A8 2021/4/20 8:57, Thomas Monjalon =E5=86=99=E9=81=93:
> > 08/04/2021 12:14, Min Hu (Connor):
> >> From: Chengwen Feng <fengchengwen@huawei.com>
> >>
> >> The ethtool use the socket_id which get from rte_eth_dev_socket_id API
> >> in the init stage, but use the rte_socket_id API to get socket_id when
> >> setting ringparam.
> >>
> >> This patch make sure it call rte_eth_dev_socket_id API to get
> >> socket_id when setting ringparam.
> >>
> >> Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample =
application")
> >> Cc: stable@dpdk.org
> >=20
> > The explanation is missing something.
> > Please tell why it is wrong.
> >=20
> >=20
> Hi, Thomas,
> It is advised that bind queue resources to the NUMA node where the
> device resides, not the NUMA node corresponding to the thread where the
> command line resides. And that will be better.
I know, but in the commit message, you give function name
without saying that rte_socket_id is the running socket
while rte_eth_dev_socket_id is the device socket.
Please make your commit messages more obvious for anyone reading.
Story telling is usually a good approach.