From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96D0543B20; Wed, 14 Feb 2024 00:33:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B54C4029B; Wed, 14 Feb 2024 00:33:35 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 91D3E4029B for ; Wed, 14 Feb 2024 00:33:33 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 92BBA207ECBB; Tue, 13 Feb 2024 15:33:32 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 92BBA207ECBB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1707867212; bh=xYI776BgYzJ2GguOVt5bLr9k/fd9Mr5BMhPDvsYMNsk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LZD63asP68vJn21Q6NGNyx/gt3Gia7JbIM9azQVrobJmL0hrVW/+hjDmC+K411UF2 I3jR0Arp6YjR67V1pKqodFKv0TTONNig2FU3j9M8RzdS13Xtvfrb0n1VVqEHYRBZd6 /QU1OLw27MDfeM5XdCTcNfXSffTH9TyOsQZo11OA= From: Tyler Retzlaff To: dev@dpdk.org Cc: Andrew Boyer , Andrew Rybchenko , Bruce Richardson , Chenbo Xia , Konstantin Ananyev , Maxime Coquelin , mb@smartsharesystems.com, Tyler Retzlaff Subject: [PATCH v3] RFC deprecate RTE_MARKER in struct rte_mbuf Date: Tue, 13 Feb 2024 15:33:28 -0800 Message-Id: <1707867209-1901-1-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1706657173-26166-2-git-send-email-roretzla@linux.microsoft.com> References: <1706657173-26166-2-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Here is the latest iteration of the proposed change to allow struct rte_mbuf to be consumed by MSVC. * Introduce an internal __rte_marker macro conditionally expanded for MSVC vs existing users of the struct. At some point we can uncomment __rte_deprecated to assist migration away from the current marker fields for applications after appropriate announcement periods etc.. * Introduce anonymous unions to allow aliasing of the previous named offsets by a *new* name. The intention would be to convert the dpdk tree to use the new names along with this change and enable __rte_deprecated for dpdk builds (not applications) to avoid accidental re-introduction. * The anonymous unions are now also used to pad cacheline0 and cacheline1 instead of __rte_cache_min_aligned. * Converted the type of the fields for the named markers to char[] instead of uint8_t[]. Tyler Retzlaff (1): mbuf: deprecate GCC marker in rte mbuf struct lib/eal/include/rte_common.h | 6 + lib/mbuf/rte_mbuf_core.h | 365 +++++++++++++++++++++++-------------------- 2 files changed, 201 insertions(+), 170 deletions(-) -- 1.8.3.1