From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 4EA371B3A8; Tue, 23 Oct 2018 11:37:26 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DEF9420DD4; Tue, 23 Oct 2018 05:37:25 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 23 Oct 2018 05:37:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=aYkxvD08b8STSk90On3uTktECd44Ig2rnKwnAxgtShE=; b=i8+0BXQS9GMo 1mH8mBfIRYqPMhWUhGXfyhItyGyzXCkr8RPiKtei0N0TR3js/7+NhtLRxSlA9P6Z AsDy5mCqbh2PF8p27GpTjG+XU09v0cKSXxZ6qWtnTAGZhrEUKr4N7dYZrQtHJC4w pNMNvM1bD4z1tFe1mGhRrB/Stod9qlA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=aYkxvD08b8STSk90On3uTktECd44Ig2rnKwnAxgtS hE=; b=QHL1RNPVFwODnpapu3Ip6IXswWOdn+Eyi90OlujJyDkhY6+54s7QribUz VQ+DW75J1skPU0iu6SdSr9+YkQ9WT95njsoGgP0SIAubhcV+Lwbj86IuGvfLZOlk NgR+V2egDmezaQIsiM1bZpceSZMtm0oBns6u53RnYW7wvM6j3aJatso76yyd21YY sv9k28myo/BCwnS51bbHaltxLbljUT6+c6op9phe7H5l/BrgNmtYRHASu9oW573I ILDCbRexDJfluKLc7z4hZvFb4aAX+4/Xc2yoJD2GCxdyDSLasdlG6ektODUyGfu3 EqisVyBC04E0ab2AHtDd6tjArl3VQ== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D95D2102E4; Tue, 23 Oct 2018 05:37:24 -0400 (EDT) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, stable@dpdk.org Date: Tue, 23 Oct 2018 11:37:27 +0200 Message-ID: <1707970.63ogE5Frsa@xps> In-Reply-To: <6977287.CUEHYN7lHI@xps> References: <9183826f1b6f3bb3d80cdde12fbd59f07f4df348.1540212745.git.anatoly.burakov@intel.com> <6977287.CUEHYN7lHI@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mem: fix resource leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Oct 2018 09:37:26 -0000 22/10/2018 22:34, Thomas Monjalon: > 22/10/2018 14:57, Anatoly Burakov: > > Segment preallocation code allocates an array of structures on the > > heap but does not free the memory afterwards. Fix it by freeing it > > at the end of the function, and changing control flow to always go > > through that code path. > > > > Fixes: 1dd342d0fdc4 ("mem: improve segment list preallocation") > > > > Coverity ID: 323524 > > > > Cc: stable@dpdk.org > > The right order for these tags is: > > Coverity issue: 323524 > Fixes: 1dd342d0fdc4 ("mem: improve segment list preallocation") > Cc: stable@dpdk.org > > > Signed-off-by: Anatoly Burakov Applied, thanks