From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7128A0547; Thu, 11 Feb 2021 23:19:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6347122A24E; Thu, 11 Feb 2021 23:19:32 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 3536940147; Thu, 11 Feb 2021 23:19:31 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id B865AA79; Thu, 11 Feb 2021 17:19:29 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 11 Feb 2021 17:19:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= 1pKY1LqL75L19Z2ugvDQGEI7jaxGaLZYXxdh/xoBHhI=; b=1fovfw0sJyW4zPeK yvp2ZqgoST6gGij6Hh7fHucdKoqjsUIphI//daZSAVsXJtDZIYVe1RenGxpIFSzz Na2Gcf/MVVBOQGOifL7Jo0BhJv/KnhaxylOLYco4oZeUGgu+/u0IV+NaO1jhIiGc bsny4OCbaFu2gyGhgEmyhnd1qP7V+xDzvgsejwBvAVjYhi12sV2PFC7A5NfsbTkU jpZqok56xjUKWQlTXwtj1v2jf7uHcbe36tMa/y9bQmLAOl+sA3sGY+ZboShUz8AJ M9YgPgUn3GWcWefNUTyOwmO7HJ7Kdfy67gv2/ocLJBwJxCtpP3UzTHH/WgpL+CRd EyS9yg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=1pKY1LqL75L19Z2ugvDQGEI7jaxGaLZYXxdh/xoBH hI=; b=GC3A5u0zZfbBqdqBGGSqSqXG7pXakpsfMAse8FyOKq4Oe45qnULy+UWMq kURU+SgAEKT8p+ThpP1eAH31WtO/s1/JRtpVL8/erKyq+1Fa5TBYbO5EjV3kKN0Q D74vEb3yGn7WkQ1UKe1/7muUb2kEZx8M5hXJc4Hg8uZl+A6Edzq0Mk6eTuxq7MLC vyDKg5IKD5n7jV7eV5lTB1cGJY3A3kmCCu7IupExHcCKQdTFcbLGdf+KdDI6CeqS ok6wBAHrPldwgESnANYPJeM+CPVFV24/wSc0cEXZEIIg62dmzT80kP+R+4I9ZvCS NNdpkiNkQ2v8AtFB/ol+0TIEuZFwA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrheelgdduheelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 66E631080064; Thu, 11 Feb 2021 17:19:28 -0500 (EST) From: Thomas Monjalon To: "Liu, Yongxin" Cc: dev@dpdk.org, "Burakov, Anatoly" , stable@dpdk.org Date: Thu, 11 Feb 2021 23:19:26 +0100 Message-ID: <1708096.ay8Ok6BTUT@thomas> In-Reply-To: <4fedb4c2-9891-bdfc-588e-2d047b70bca1@intel.com> References: <20201118025854.13455-1-yongxin.liu@windriver.com> <4fedb4c2-9891-bdfc-588e-2d047b70bca1@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5] usertools/devbind: fix binding for built-in kernel drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > >> A driver can be loaded as a dynamic module or a built-in module. > >> In commit 681a67288655 ("usertools: check if module is loaded before > >> binding"), script only checks modules in /sys/module/. > >> > >> However, for built-in kernel driver, it only shows up in /sys/module/, if > >> it has a version or at least one parameter. So add check for modules in > >> /lib/modules/$(uname -r)/modules.builtin. > >> > >> Signed-off-by: Yongxin Liu > > Apologies for the delay. > > Reviewed-by: Anatoly Burakov Fixes: 681a67288655 ("usertools: check if module is loaded before binding") Cc: stable@dpdk.org Applied, thanks