* [dpdk-dev] [PATCH] igb_uio: fix build issue with lock down checks
@ 2018-06-29 10:13 David Marchand
2018-06-29 10:54 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2018-06-29 10:13 UTC (permalink / raw)
To: ferruh.yigit; +Cc: dev
Caught on ubuntu-16.04 with hwe kernel for aarch64:
$ uname -a
Linux ubuntu1604arm64es 4.13.0-43-generic #48~16.04.1-Ubuntu SMP Thu May
17 13:08:01 UTC 2018 aarch64 aarch64 aarch64 GNU/Linux
== Build kernel/linux/igb_uio
CC [M] .../kernel/linux/igb_uio/igb_uio.o
In file included from .../kernel/linux/igb_uio/igb_uio.c:20:0:
.../igb_uio/compat.h: In function ‘igbuio_kernel_is_locked_down’:
.../igb_uio/compat.h:146:7:
error: "CONFIG_EFI_SECURE_BOOT_LOCK_DOWN" is not defined [-Werror=undef]
#elif CONFIG_EFI_SECURE_BOOT_LOCK_DOWN
^
cc1: all warnings being treated as errors
Fixes: d67014c3d38b ("igb_uio: fail and log if kernel lock down is enabled")
Signed-off-by: David Marchand <david.marchand@6wind.com>
---
kernel/linux/igb_uio/compat.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/linux/igb_uio/compat.h b/kernel/linux/igb_uio/compat.h
index e5df515..8dbb896 100644
--- a/kernel/linux/igb_uio/compat.h
+++ b/kernel/linux/igb_uio/compat.h
@@ -143,7 +143,7 @@ static inline bool igbuio_kernel_is_locked_down(void)
#ifdef CONFIG_LOCK_DOWN_KERNEL
#ifdef CONFIG_LOCK_DOWN_IN_EFI_SECURE_BOOT
return kernel_is_locked_down(NULL);
-#elif CONFIG_EFI_SECURE_BOOT_LOCK_DOWN
+#elif defined(CONFIG_EFI_SECURE_BOOT_LOCK_DOWN)
return kernel_is_locked_down();
#else
return false;
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] igb_uio: fix build issue with lock down checks
2018-06-29 10:13 [dpdk-dev] [PATCH] igb_uio: fix build issue with lock down checks David Marchand
@ 2018-06-29 10:54 ` Ferruh Yigit
2018-07-11 16:50 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2018-06-29 10:54 UTC (permalink / raw)
To: David Marchand; +Cc: dev
On 6/29/2018 11:13 AM, David Marchand wrote:
> Caught on ubuntu-16.04 with hwe kernel for aarch64:
>
> $ uname -a
> Linux ubuntu1604arm64es 4.13.0-43-generic #48~16.04.1-Ubuntu SMP Thu May
> 17 13:08:01 UTC 2018 aarch64 aarch64 aarch64 GNU/Linux
>
> == Build kernel/linux/igb_uio
> CC [M] .../kernel/linux/igb_uio/igb_uio.o
> In file included from .../kernel/linux/igb_uio/igb_uio.c:20:0:
> .../igb_uio/compat.h: In function ‘igbuio_kernel_is_locked_down’:
> .../igb_uio/compat.h:146:7:
> error: "CONFIG_EFI_SECURE_BOOT_LOCK_DOWN" is not defined [-Werror=undef]
> #elif CONFIG_EFI_SECURE_BOOT_LOCK_DOWN
> ^
> cc1: all warnings being treated as errors
>
> Fixes: d67014c3d38b ("igb_uio: fail and log if kernel lock down is enabled")
> Signed-off-by: David Marchand <david.marchand@6wind.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Thanks for the fix.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] igb_uio: fix build issue with lock down checks
2018-06-29 10:54 ` Ferruh Yigit
@ 2018-07-11 16:50 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-07-11 16:50 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Ferruh Yigit
29/06/2018 12:54, Ferruh Yigit:
> On 6/29/2018 11:13 AM, David Marchand wrote:
> > Caught on ubuntu-16.04 with hwe kernel for aarch64:
> >
> > $ uname -a
> > Linux ubuntu1604arm64es 4.13.0-43-generic #48~16.04.1-Ubuntu SMP Thu May
> > 17 13:08:01 UTC 2018 aarch64 aarch64 aarch64 GNU/Linux
> >
> > == Build kernel/linux/igb_uio
> > CC [M] .../kernel/linux/igb_uio/igb_uio.o
> > In file included from .../kernel/linux/igb_uio/igb_uio.c:20:0:
> > .../igb_uio/compat.h: In function ‘igbuio_kernel_is_locked_down’:
> > .../igb_uio/compat.h:146:7:
> > error: "CONFIG_EFI_SECURE_BOOT_LOCK_DOWN" is not defined [-Werror=undef]
> > #elif CONFIG_EFI_SECURE_BOOT_LOCK_DOWN
> > ^
> > cc1: all warnings being treated as errors
> >
> > Fixes: d67014c3d38b ("igb_uio: fail and log if kernel lock down is enabled")
> > Signed-off-by: David Marchand <david.marchand@6wind.com>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Thanks for the fix.
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-11 16:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-29 10:13 [dpdk-dev] [PATCH] igb_uio: fix build issue with lock down checks David Marchand
2018-06-29 10:54 ` Ferruh Yigit
2018-07-11 16:50 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).