From: Thomas Monjalon <thomas@monjalon.net>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Chenbo Xia <chenbox@nvidia.com>,
Tomasz Duszynski <tduszynski@marvell.com>,
Stephen Hemminger <stephen@networkplumber.org>,
dev@dpdk.org
Subject: Re: [PATCH v3 2/3] eal: handle sysconf(_SC_PAGESIZE) negative return value
Date: Fri, 27 Jun 2025 17:58:10 +0200 [thread overview]
Message-ID: <17086222.mzqWEpnEhh@thomas> (raw)
In-Reply-To: <20250624080333.127618-3-mb@smartsharesystems.com>
24/06/2025 10:03, Morten Brørup:
> + if ((ssize_t)page_size < 0)
> + rte_panic("sysconf(_SC_PAGESIZE) failed: %s",
> + errno == 0 ? "Indeterminate" : strerror(errno));
We don't want more rte_panic().
You could log the problem and return 0 here.
It will be a problem later, but it may allow the application to cleanup
instead of abrupting crashing.
next prev parent reply other threads:[~2025-06-27 15:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 13:13 [PATCH] eal: handle sysconf() " Morten Brørup
2025-06-12 14:06 ` [PATCH v2] eal: handle sysconf(_SC_PAGESIZE) " Morten Brørup
2025-06-13 9:55 ` Burakov, Anatoly
2025-06-24 8:03 ` [PATCH v3 0/3] " Morten Brørup
2025-06-24 8:03 ` [PATCH v3 1/3] eal/unix: fix log message for madvise() failure Morten Brørup
2025-06-27 15:56 ` Thomas Monjalon
2025-06-27 16:47 ` Morten Brørup
2025-06-27 17:34 ` Thomas Monjalon
2025-06-27 17:51 ` Morten Brørup
2025-06-24 8:03 ` [PATCH v3 2/3] eal: handle sysconf(_SC_PAGESIZE) negative return value Morten Brørup
2025-06-27 15:58 ` Thomas Monjalon [this message]
2025-06-27 16:38 ` Morten Brørup
2025-06-27 17:35 ` Thomas Monjalon
2025-06-27 17:49 ` Morten Brørup
2025-06-27 18:30 ` Thomas Monjalon
2025-06-24 8:03 ` [PATCH v3 3/3] pmu: " Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17086222.mzqWEpnEhh@thomas \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=chenbox@nvidia.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=mb@smartsharesystems.com \
--cc=roretzla@linux.microsoft.com \
--cc=stephen@networkplumber.org \
--cc=tduszynski@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).