From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id BB69943BF6;
	Mon, 26 Feb 2024 21:20:46 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 9E35A42ECC;
	Mon, 26 Feb 2024 21:20:01 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id E68CB42E37
 for <dev@dpdk.org>; Mon, 26 Feb 2024 21:19:49 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id B6E2F20B74CE; Mon, 26 Feb 2024 12:19:48 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B6E2F20B74CE
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1708978788;
 bh=HVkrC6vdIUv3u+ISu9fg5FLffWiIIFjMQvtr9Xlw6Sg=;
 h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
 b=QGlQP11HhbnvqTju5bcOEOnzeKWTASNuCyn06xJC/uXBcUM7KzsfeEwvOBOnZEf6n
 E0d5QJivq4ZadMaev05VLPOD1FYHSk4RkdpDvV3XaOVSR3fwoPqa+4AktXoevnJvWe
 ntLl6N5LKBeS9+1AfWeC3+FpzHXPETGk0SIZSrFM=
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: dev@dpdk.org
Cc: Anatoly Burakov <anatoly.burakov@intel.com>,
 Ashish Gupta <ashish.gupta@marvell.com>, Chenbo Xia <chenbox@nvidia.com>,
 Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
 David Hunt <david.hunt@intel.com>, Fan Zhang <fanzhang.oss@gmail.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>,
 Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
 Jasvinder Singh <jasvinder.singh@intel.com>,
 Jerin Jacob <jerinj@marvell.com>,
 Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
 Maxime Coquelin <maxime.coquelin@redhat.com>,
 Reshma Pattan <reshma.pattan@intel.com>,
 Sachin Saxena <sachin.saxena@nxp.com>,
 Sivaprasad Tummala <sivaprasad.tummala@amd.com>,
 Srikanth Yalavarthi <syalavarthi@marvell.com>,
 Stephen Hemminger <stephen@networkplumber.org>,
 Sunil Kumar Kori <skori@marvell.com>, bruce.richardson@intel.com,
 mb@smartsharesystems.com, thomas@monjalon.net,
 Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: [PATCH v3 14/16] eal: stop using variadic argument pack extension
Date: Mon, 26 Feb 2024 12:19:44 -0800
Message-Id: <1708978786-6740-15-git-send-email-roretzla@linux.microsoft.com>
X-Mailer: git-send-email 1.8.3.1
In-Reply-To: <1708978786-6740-1-git-send-email-roretzla@linux.microsoft.com>
References: <1707774557-16012-1-git-send-email-roretzla@linux.microsoft.com>
 <1708978786-6740-1-git-send-email-roretzla@linux.microsoft.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Use RTE_LOG_LINE_PREFIX instead of EAL_LOG in macro expansions
which allow a prefix and arguments to be inserted into the log line
without the need to use the ## args variadic argument pack extension.

Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
 lib/eal/common/eal_trace.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/eal/common/eal_trace.h b/lib/eal/common/eal_trace.h
index bd082a0..5526267 100644
--- a/lib/eal/common/eal_trace.h
+++ b/lib/eal/common/eal_trace.h
@@ -16,11 +16,11 @@
 #include "eal_private.h"
 #include "eal_thread.h"
 
-#define trace_err(fmt, args...) \
-	EAL_LOG(ERR, "%s():%u " fmt, __func__, __LINE__, ## args)
+#define trace_err(...) \
+	RTE_LOG_LINE_PREFIX(ERR, EAL, "%s():%u ", __func__ RTE_LOG_COMMA __LINE__, __VA_ARGS__)
 
-#define trace_crit(fmt, args...) \
-	EAL_LOG(CRIT, "%s():%u " fmt, __func__, __LINE__, ## args)
+#define trace_crit(...) \
+	RTE_LOG_LINE_PREFIX(CRIT, EAL, "%s():%u ", __func__ RTE_LOG_COMMA __LINE__, __VA_ARGS__)
 
 #define TRACE_CTF_MAGIC 0xC1FC1FC1
 #define TRACE_MAX_ARGS	32
-- 
1.8.3.1