From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 99E2143C03;
Tue, 27 Feb 2024 06:44:20 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 626ED42F0C;
Tue, 27 Feb 2024 06:42:40 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
by mails.dpdk.org (Postfix) with ESMTP id 4D9CE42E4E
for <dev@dpdk.org>; Tue, 27 Feb 2024 06:41:43 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
id A889020B74D1; Mon, 26 Feb 2024 21:41:41 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A889020B74D1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
s=default; t=1709012501;
bh=43J41FUN8U97ef9HAWZHV2AQLsuA5wCPXesxdNMpgMw=;
h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
b=MzcKe6Y+nlKB6DGivU47xnSAnhoVx8XY7i3tUPdxBXiTKF7bb19gIWNMuWQArnnEd
Tm59SPRtr+JOTu0M79ALvEao26Vq3S3TRsQwEbJzb3pb/5jgJBXbwOkb3oznqsmZlz
I8ajPzLPuviEVDv9jE5xopx4Smx+7PnNGRbDf2UM=
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: dev@dpdk.org
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>,
Andrew Boyer <andrew.boyer@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Bruce Richardson <bruce.richardson@intel.com>,
Chenbo Xia <chenbox@nvidia.com>, Chengwen Feng <fengchengwen@huawei.com>,
Dariusz Sosnowski <dsosnowski@nvidia.com>,
David Christensen <drc@linux.vnet.ibm.com>,
Hyong Youb Kim <hyonkim@cisco.com>, Jerin Jacob <jerinj@marvell.com>,
Jie Hai <haijie1@huawei.com>, Jingjing Wu <jingjing.wu@intel.com>,
John Daley <johndale@cisco.com>, Kevin Laatz <kevin.laatz@intel.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
Maciej Czekaj <mczekaj@marvell.com>, Matan Azrad <matan@nvidia.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>, Ori Kam <orika@nvidia.com>,
Ruifeng Wang <ruifeng.wang@arm.com>, Satha Rao <skoteshwar@marvell.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Suanming Mou <suanmingm@nvidia.com>, Sunil Kumar Kori <skori@marvell.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Yisen Zhuang <yisen.zhuang@huawei.com>,
Yuying Zhang <Yuying.Zhang@intel.com>, mb@smartsharesystems.com,
Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: [PATCH v6 17/23] net/thunderx: use mbuf descriptor accessors
Date: Mon, 26 Feb 2024 21:41:33 -0800
Message-Id: <1709012499-12813-18-git-send-email-roretzla@linux.microsoft.com>
X-Mailer: git-send-email 1.8.3.1
In-Reply-To: <1709012499-12813-1-git-send-email-roretzla@linux.microsoft.com>
References: <1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com>
<1709012499-12813-1-git-send-email-roretzla@linux.microsoft.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Use
new rte_mbuf_rearm_data and rte_mbuf_rx_descriptor_fields1 accessors
that provide a compatible type pointer without using the marker fields.
Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
drivers/net/thunderx/nicvf_ethdev.c | 4 +---
drivers/net/thunderx/nicvf_rxtx.h | 4 ++--
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c
index 609d95d..722751c 100644
--- a/drivers/net/thunderx/nicvf_ethdev.c
+++ b/drivers/net/thunderx/nicvf_ethdev.c
@@ -1306,7 +1306,6 @@ enum nicvf_link_speed {
static inline void
nicvf_rxq_mbuf_setup(struct nicvf_rxq *rxq)
{
- uintptr_t p;
struct rte_mbuf mb_def;
struct nicvf *nic = rxq->nic;
@@ -1328,8 +1327,7 @@ enum nicvf_link_speed {
/* Prevent compiler reordering: rearm_data covers previous fields */
rte_compiler_barrier();
- p = (uintptr_t)&mb_def.rearm_data;
- rxq->mbuf_initializer.value = *(uint64_t *)p;
+ rxq->mbuf_initializer.value = *rte_mbuf_rearm_data(&mb_def);
}
static int
diff --git a/drivers/net/thunderx/nicvf_rxtx.h b/drivers/net/thunderx/nicvf_rxtx.h
index 4b83e33..7c07cde 100644
--- a/drivers/net/thunderx/nicvf_rxtx.h
+++ b/drivers/net/thunderx/nicvf_rxtx.h
@@ -66,7 +66,7 @@ static inline uint16_t __attribute__((const))
#else
init.value += apad;
#endif
- *(uint64_t *)(&pkt->rearm_data) = init.value;
+ *rte_mbuf_rearm_data(pkt) = init.value;
}
static inline void
@@ -80,7 +80,7 @@ static inline uint16_t __attribute__((const))
init.value += apad;
#endif
init.fields.nb_segs = nb_segs;
- *(uint64_t *)(&pkt->rearm_data) = init.value;
+ *rte_mbuf_rearm_data(pkt) = init.value;
}
uint32_t nicvf_dev_rx_queue_count(void *rx_queue);
--
1.8.3.1