DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>,
	Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
	Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
	Sameh Gobriel <sameh.gobriel@intel.com>,
	Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
	Yipeng Wang <yipeng1.wang@intel.com>,
	mb@smartsharesystems.com, fengchengwen@huawei.com,
	Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: [PATCH v5 2/6] rcu: replace zero length array with flex array
Date: Wed,  6 Mar 2024 12:13:52 -0800	[thread overview]
Message-ID: <1709756036-24068-3-git-send-email-roretzla@linux.microsoft.com> (raw)
In-Reply-To: <1709756036-24068-1-git-send-email-roretzla@linux.microsoft.com>

Zero length arrays are GNU extension. Replace with
standard flex array.

Add a temporary suppression for rte_pipeline_table_entry
libabigail bug:

Bugzilla ID: https://sourceware.org/bugzilla/show_bug.cgi?id=31377

Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
---
 devtools/libabigail.abignore | 3 +++
 lib/rcu/rcu_qsbr_pvt.h       | 2 +-
 lib/rcu/rte_rcu_qsbr.h       | 2 +-
 3 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
index 645d289..25c73a5 100644
--- a/devtools/libabigail.abignore
+++ b/devtools/libabigail.abignore
@@ -35,5 +35,8 @@
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 
 [suppress_type]
+	name = rte_rcu_qsbr
+
+[suppress_type]
 	name = rte_eth_fp_ops
 	has_data_member_inserted_between = {offset_of(reserved2), end}
diff --git a/lib/rcu/rcu_qsbr_pvt.h b/lib/rcu/rcu_qsbr_pvt.h
index 5fd7ca2..96d05e6 100644
--- a/lib/rcu/rcu_qsbr_pvt.h
+++ b/lib/rcu/rcu_qsbr_pvt.h
@@ -52,7 +52,7 @@ struct rte_rcu_qsbr_dq {
  */
 typedef struct {
 	uint64_t token;  /**< Token */
-	uint8_t elem[0]; /**< Pointer to user element */
+	uint8_t elem[]; /**< Pointer to user element */
 } __attribute__((__may_alias__)) __rte_rcu_qsbr_dq_elem_t;
 
 #endif /* _RTE_RCU_QSBR_PVT_H_ */
diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h
index 0506191..ed3dd6d 100644
--- a/lib/rcu/rte_rcu_qsbr.h
+++ b/lib/rcu/rte_rcu_qsbr.h
@@ -107,7 +107,7 @@ struct __rte_cache_aligned rte_rcu_qsbr {
 	uint32_t max_threads;
 	/**< Maximum number of threads using this QS variable */
 
-	alignas(RTE_CACHE_LINE_SIZE) struct rte_rcu_qsbr_cnt qsbr_cnt[0];
+	alignas(RTE_CACHE_LINE_SIZE) struct rte_rcu_qsbr_cnt qsbr_cnt[];
 	/**< Quiescent state counter array of 'max_threads' elements */
 
 	/**< Registered thread IDs are stored in a bitmap array,
-- 
1.8.3.1


  parent reply	other threads:[~2024-03-06 20:14 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-24 22:17 [PATCH 0/2] more replacement of zero length array Tyler Retzlaff
2024-01-24 22:17 ` [PATCH 1/2] hash: replace zero length array with flex array Tyler Retzlaff
2024-01-24 22:57   ` Honnappa Nagarahalli
2024-01-25  7:16   ` Morten Brørup
2024-01-24 22:17 ` [PATCH 2/2] rcu: " Tyler Retzlaff
2024-01-24 22:57   ` Honnappa Nagarahalli
2024-01-25  7:14   ` Morten Brørup
2024-01-25 12:57 ` [PATCH 0/2] more replacement of zero length array fengchengwen
2024-02-12 22:36 ` [PATCH v2 0/4] " Tyler Retzlaff
2024-02-12 22:36   ` [PATCH v2 1/4] hash: replace zero length array with flex array Tyler Retzlaff
2024-02-12 22:36   ` [PATCH v2 2/4] rcu: " Tyler Retzlaff
2024-02-12 22:36   ` [PATCH v2 3/4] fib: " Tyler Retzlaff
2024-02-12 22:36   ` [PATCH v2 4/4] pipeline: " Tyler Retzlaff
2024-02-12 22:57   ` [PATCH v2 0/4] more replacement of zero length array Stephen Hemminger
2024-02-13  8:31     ` Morten Brørup
2024-02-13 13:14   ` David Marchand
2024-02-13 19:20     ` Tyler Retzlaff
2024-02-14  7:36       ` David Marchand
2024-02-16 10:14         ` David Marchand
2024-02-16 20:46           ` Tyler Retzlaff
2024-02-18 12:31           ` Dodji Seketeli
2024-02-27 23:56 ` [PATCH v3 0/6] " Tyler Retzlaff
2024-02-27 23:56   ` [PATCH v3 1/6] hash: replace zero length array with flex array Tyler Retzlaff
2024-02-27 23:56   ` [PATCH v3 2/6] rcu: " Tyler Retzlaff
2024-02-27 23:56   ` [PATCH v3 3/6] fib: " Tyler Retzlaff
2024-02-27 23:56   ` [PATCH v3 4/6] pipeline: " Tyler Retzlaff
2024-02-27 23:56   ` [PATCH v3 5/6] lpm: " Tyler Retzlaff
2024-02-28  7:26     ` Morten Brørup
2024-02-27 23:56   ` [PATCH v3 6/6] table: " Tyler Retzlaff
2024-02-28  7:27     ` Morten Brørup
2024-02-29 22:58 ` [PATCH v4 0/6] more replacement of zero length array Tyler Retzlaff
2024-02-29 22:58   ` [PATCH v4 1/6] hash: replace zero length array with flex array Tyler Retzlaff
2024-02-29 22:58   ` [PATCH v4 2/6] rcu: " Tyler Retzlaff
2024-02-29 22:58   ` [PATCH v4 3/6] fib: " Tyler Retzlaff
2024-02-29 22:58   ` [PATCH v4 4/6] pipeline: " Tyler Retzlaff
2024-02-29 22:58   ` [PATCH v4 5/6] lpm: " Tyler Retzlaff
2024-03-01  8:12     ` Morten Brørup
2024-02-29 22:58   ` [PATCH v4 6/6] table: " Tyler Retzlaff
2024-03-01  8:13     ` Morten Brørup
2024-03-06 19:39   ` [PATCH v4 0/6] more replacement of zero length array Tyler Retzlaff
2024-03-06 20:13 ` [PATCH v5 " Tyler Retzlaff
2024-03-06 20:13   ` [PATCH v5 1/6] hash: replace zero length array with flex array Tyler Retzlaff
2024-03-06 20:52     ` Medvedkin, Vladimir
2024-03-06 20:13   ` Tyler Retzlaff [this message]
2024-03-06 20:13   ` [PATCH v5 3/6] fib: " Tyler Retzlaff
2024-03-06 20:53     ` Medvedkin, Vladimir
2024-03-06 20:13   ` [PATCH v5 4/6] pipeline: " Tyler Retzlaff
2024-03-06 20:13   ` [PATCH v5 5/6] lpm: " Tyler Retzlaff
2024-03-06 20:53     ` Medvedkin, Vladimir
2024-03-06 20:13   ` [PATCH v5 6/6] table: " Tyler Retzlaff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1709756036-24068-3-git-send-email-roretzla@linux.microsoft.com \
    --to=roretzla@linux.microsoft.com \
    --cc=bruce.richardson@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=fengchengwen@huawei.com \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=mb@smartsharesystems.com \
    --cc=sameh.gobriel@intel.com \
    --cc=vladimir.medvedkin@intel.com \
    --cc=yipeng1.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).