From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by dpdk.org (Postfix) with ESMTP id 9A8267E89 for ; Wed, 22 Oct 2014 10:37:35 +0200 (CEST) Received: by mail-wi0-f175.google.com with SMTP id d1so687991wiv.2 for ; Wed, 22 Oct 2014 01:45:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=O5fpCUQfbBnbyMSryfs/kB+6a3Z4/bqJISiXmqM/lZw=; b=ZZVC2RfMNcVZlKk17b/46h9Bi4Pa9cvOg9R/i4H4FoTT5Mb+CtjAUcr27843HmcISV j4l5lSifNum4E/R2QeanrsBM176zRbkr6ilWbpUq95/cyEhgd809IjehcHdbubgd0EU9 3wqUnMHEZFtENd2I80J3pYltR/78+lUyzCsUl8ruFzL57i8f4T47o8s5/B/USPwBiw/B fjhc4LfAVWHY53kgzUTym27TGnxX6LLtFcC/4/kVPd5Kn8D2Zj0/JpXvElfmPJSLQmD2 kpZ7v8PEAZHz/n+MXJzKdWmZ+Hs563pltQmrUVFrrhwhfHFZFOUtdRGUocmy5maNjdZp RFsg== X-Gm-Message-State: ALoCoQmyKZaPp4GzRFaNciYfUS6ClYyg68ofnbrFJUclgkjRTUmZPya3jDnbvbXDHm+1hyKiwLL3 X-Received: by 10.180.107.69 with SMTP id ha5mr3777141wib.69.1413967555199; Wed, 22 Oct 2014 01:45:55 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id u9sm1120643wiv.8.2014.10.22.01.45.53 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Oct 2014 01:45:54 -0700 (PDT) From: Thomas Monjalon To: "Liu, Jijiang" Date: Wed, 22 Oct 2014 10:45:38 +0200 Message-ID: <1710340.mrZid3JfsP@xps13> Organization: 6WIND User-Agent: KMail/4.14.1 (Linux/3.16.4-1-ARCH; KDE/4.14.1; x86_64; ; ) In-Reply-To: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D82548@SHSMSX101.ccr.corp.intel.com> References: <1413881168-20239-1-git-send-email-jijiang.liu@intel.com> <2450996.3KDeDxoTz7@xps13> <1ED644BD7E0A5F4091CF203DAFB8E4CC01D82548@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 1/9] librte_mbuf:the rte_mbuf structure changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Oct 2014 08:37:35 -0000 2014-10-21 14:14, Liu, Jijiang: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2014-10-21 16:46, Jijiang Liu: > > > - uint16_t reserved2; /**< Unused field. Required for padding */ > > > + > > > + /** > > > + * Packet type, which is used to indicate ordinary L2 packet format and > > > + * also tunneled packet format such as IP in IP, IP in GRE, MAC in GRE > > > + * and MAC in UDP. > > > + */ > > > + uint16_t packet_type; > > > > Why not name it "l2_type"? > > In datasheet, this term is called packet type(s). That's exactly the point I want you really understand! This is a field in generic mbuf structure, so your datasheet has no value here. > Personally , I think packet type is more clear what meaning of this field is . ^_^ You cannot add an API field without knowing what will be its generic meaning. Please think about it and describe its scope. Thanks -- Thomas