DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] app/testbbdev: fix division or modulo by float zero
@ 2018-01-31 12:56 Amr Mokhtar
  2018-01-31 14:56 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Amr Mokhtar @ 2018-01-31 12:56 UTC (permalink / raw)
  To: dev; +Cc: Amr Mokhtar

check that iter > 0 before division

Coverity issue: 257027
Coverity issue: 257038
Coverity issue: 257014

Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev")

Signed-off-by: Amr Mokhtar <amr.mokhtar@intel.com>
---
 app/test-bbdev/test_bbdev_perf.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index f7b51ca..8f6896c 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -1805,7 +1805,7 @@ operation_latency_test(struct active_device *ad,
 				op_params->ref_enc_op, ad->dev_id, queue_id,
 				num_to_process, burst_sz, &total_time);
 
-	if (iter < 0)
+	if (iter <= 0)
 		return TEST_FAILED;
 
 	printf("\toperation avg. latency: %lg cycles, %lg us\n",
@@ -1955,7 +1955,7 @@ offload_latency_test(struct active_device *ad,
 				num_to_process, burst_sz, &enq_total_time,
 				&deq_total_time);
 
-	if (iter < 0)
+	if (iter <= 0)
 		return TEST_FAILED;
 
 	printf("\tenq offload avg. latency: %lg cycles, %lg us\n",
@@ -2047,7 +2047,7 @@ offload_latency_empty_q_test(struct active_device *ad,
 		iter = offload_latency_empty_q_test_enc(ad->dev_id, queue_id,
 				num_to_process, burst_sz, &deq_total_time);
 
-	if (iter < 0)
+	if (iter <= 0)
 		return TEST_FAILED;
 
 	printf("\tempty deq offload avg. latency: %lg cycles, %lg us\n",
-- 
2.7.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-01-31 14:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-31 12:56 [dpdk-dev] [PATCH] app/testbbdev: fix division or modulo by float zero Amr Mokhtar
2018-01-31 14:56 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).