* [PATCH v2] app/testpmd: fix flex item compilation error
@ 2023-02-21 10:02 Rongwei Liu
2023-02-21 20:09 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Rongwei Liu @ 2023-02-21 10:02 UTC (permalink / raw)
To: dev, matan, viacheslavo, orika, thomas
Cc: rasland, stable, gaodaxue, Aman Singh, Yuying Zhang
When configuring meson with option "--optimization=1", gcc
complains "maybe-uninitialized" warning and it was treated as
error since Werror is enabled.
Assign fp to NULL at declaration can avoid this.
Bugzilla ID: 1163
Fixes: c8e25fbf1440 ("ethdev: add flow flex modify")
Cc: stable@dpdk.org
Reported-by: gaodaxue <daxuex.gao@intel.com>
Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
---
app/test-pmd/cmdline_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index f1991a5a9a..9309607f11 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -8992,7 +8992,7 @@ parse_vc_modify_field_level(struct context *ctx, const struct token *token,
unsigned int size)
{
struct rte_flow_action_modify_field *action;
- struct flex_item *fp;
+ struct flex_item *fp = NULL;
uint32_t val;
struct buffer *out = buf;
char *end;
--
2.27.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] app/testpmd: fix flex item compilation error
2023-02-21 10:02 [PATCH v2] app/testpmd: fix flex item compilation error Rongwei Liu
@ 2023-02-21 20:09 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2023-02-21 20:09 UTC (permalink / raw)
To: Rongwei Liu
Cc: dev, matan, viacheslavo, orika, rasland, stable, gaodaxue,
Aman Singh, Yuying Zhang
21/02/2023 11:02, Rongwei Liu:
> When configuring meson with option "--optimization=1", gcc
> complains "maybe-uninitialized" warning and it was treated as
> error since Werror is enabled.
>
> Assign fp to NULL at declaration can avoid this.
That's probably a false positive,
but I'm OK to workaround it this way, especially in a test application.
> Bugzilla ID: 1163
> Fixes: c8e25fbf1440 ("ethdev: add flow flex modify")
> Cc: stable@dpdk.org
>
> Reported-by: gaodaxue <daxuex.gao@intel.com>
> Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
> ---
> - struct flex_item *fp;
> + struct flex_item *fp = NULL;
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-21 20:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-21 10:02 [PATCH v2] app/testpmd: fix flex item compilation error Rongwei Liu
2023-02-21 20:09 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).