From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D9FE743DEE;
	Wed,  3 Apr 2024 19:53:44 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id BE08A402E3;
	Wed,  3 Apr 2024 19:53:40 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 32AA54025C
 for <dev@dpdk.org>; Wed,  3 Apr 2024 19:53:38 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 5E51820E8CB5; Wed,  3 Apr 2024 10:53:37 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5E51820E8CB5
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1712166817;
 bh=EK6xzgydfr9WU3OsdqSW2HcxlIfS6VwMcXms+zsNN0I=;
 h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
 b=B1sWiLsDNFXy+zfFMPLrO7jcEcKpggY6lQuIEfbdnwGCdcT4bF8vgIVd51d++IYQG
 /C+mInJ8IDMiNfPtMjoGOS4ryzFM16+TO4xSyFLhuXTHdhD4NTDX+Rf/DBITZpAlcb
 QT/KoFPDwO0iSpZXURilxM+Slkl0UeUoiVGkernw=
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: dev@dpdk.org
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>,
 Andrew Boyer <andrew.boyer@amd.com>,
 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
 Bruce Richardson <bruce.richardson@intel.com>,
 Chenbo Xia <chenbox@nvidia.com>, Chengwen Feng <fengchengwen@huawei.com>,
 Dariusz Sosnowski <dsosnowski@nvidia.com>,
 David Christensen <drc@linux.vnet.ibm.com>,
 Hyong Youb Kim <hyonkim@cisco.com>, Jerin Jacob <jerinj@marvell.com>,
 Jie Hai <haijie1@huawei.com>, Jingjing Wu <jingjing.wu@intel.com>,
 John Daley <johndale@cisco.com>, Kevin Laatz <kevin.laatz@intel.com>,
 Kiran Kumar K <kirankumark@marvell.com>,
 Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
 Maciej Czekaj <mczekaj@marvell.com>, Matan Azrad <matan@nvidia.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>,
 Nithin Dabilpuram <ndabilpuram@marvell.com>, Ori Kam <orika@nvidia.com>,
 Ruifeng Wang <ruifeng.wang@arm.com>, Satha Rao <skoteshwar@marvell.com>,
 Somnath Kotur <somnath.kotur@broadcom.com>,
 Suanming Mou <suanmingm@nvidia.com>, Sunil Kumar Kori <skori@marvell.com>,
 Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
 Yisen Zhuang <yisen.zhuang@huawei.com>,
 Yuying Zhang <Yuying.Zhang@intel.com>, mb@smartsharesystems.com,
 Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: [PATCH v10 0/4] remove use of RTE_MARKER fields in libraries
Date: Wed,  3 Apr 2024 10:53:32 -0700
Message-Id: <1712166816-10624-1-git-send-email-roretzla@linux.microsoft.com>
X-Mailer: git-send-email 1.8.3.1
In-Reply-To: <1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com>
References: <1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

As per techboard meeting 2024/03/20 adopt hybrid proposal of adapting
descriptor fields and removing cachline fields.

RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove
RTE_MARKER fields.

For cacheline{0,1} fields remove fields entirely and use inline
functions to prefetch.

Provide new rearm_data and rx_descriptor_fields1 fields in anonymous
unions as single element arrays of with types matching the original
markers to maintain API compatibility.

Note: diff is easier viewed with -b due to additional nesting from
      unions / structs that have been introduced.

v10:
  * move removal notices in in release notes from 24.03 to 24.07

v9:
  * provide narrowest possible libabigail.abignore to suppress
    removal of fields that were agreed are not actual abi changes.

v8:
  * rx_descriptor_fields1 array is now constexpr sized to
    24 / sizeof(void *) so that the array encompasses fields
    accessed via the array.
  * add a comment to rx_descriptor_fields1 array site noting
    that void * type of elements is retained for compatibility
    with existing drivers.
  * clean up comments of fields in rte_mbuf to be before the
    field they apply to instead of after.
  * duplicate alignas(RTE_CACHE_LINE_MIN_SIZE) into both legs of
    conditional compile for first field of cacheline 1 instead of
    once before conditional compile block.

v7:
  * complete re-write of series, previous versions not noted. all
    reviewed-by and acked-by tags (if any) were removed.

Tyler Retzlaff (4):
  net/i40e: use inline prefetch function
  mbuf: remove rte marker fields
  security: remove rte marker fields
  cryptodev: remove rte marker fields

 devtools/libabigail.abignore            |   6 +
 doc/guides/rel_notes/release_24_07.rst  |   9 ++
 drivers/net/i40e/i40e_rxtx_vec_avx512.c |   2 +-
 lib/cryptodev/cryptodev_pmd.h           |   5 +-
 lib/mbuf/rte_mbuf.h                     |   4 +-
 lib/mbuf/rte_mbuf_core.h                | 200 +++++++++++++++++---------------
 lib/security/rte_security_driver.h      |   5 +-
 7 files changed, 128 insertions(+), 103 deletions(-)

-- 
1.8.3.1