From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id B06DF43E97;
Thu, 18 Apr 2024 01:42:31 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id DB18340685;
Thu, 18 Apr 2024 01:42:10 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
by mails.dpdk.org (Postfix) with ESMTP id 23D96402D4
for <dev@dpdk.org>; Thu, 18 Apr 2024 01:42:03 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
id 095B920FD4CE; Wed, 17 Apr 2024 16:42:01 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 095B920FD4CE
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
s=default; t=1713397322;
bh=1UgesD7xdvLHA9+rwinkWvJvo0cgvqofqVp5wXh3rSo=;
h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
b=K6GtwC5rXa7OZbEE5/iEkVMfQHYUvBoJCIYOnu1ea833hrQjyY2Asg8/kbXZ3pooM
z6CZZHdZghkRE0jquWlS3vi37sZubkJWAPp1WQMzxQgHeZauRGIvqo96FgbJwH4Imu
LPE+vF0IEL8My5eMRqjY90q5ONfpeZm9ztI2cscA=
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: dev@dpdk.org
Cc: =?UTF-8?q?Morten=20Br=C3=B8rup?= <mb@smartsharesystems.com>,
Akhil Goyal <gakhil@marvell.com>, Aman Singh <aman.deep.singh@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Bruce Richardson <bruce.richardson@intel.com>,
Chengwen Feng <fengchengwen@huawei.com>,
Dariusz Sosnowski <dsosnowski@nvidia.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Fan Zhang <fanzhang.oss@gmail.com>, Ferruh Yigit <ferruh.yigit@amd.com>,
Harry van Haaren <harry.van.haaren@intel.com>,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
Jiayu Hu <hujiayu.hu@foxmail.com>, Jingjing Wu <jingjing.wu@intel.com>,
Kevin Laatz <kevin.laatz@intel.com>,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
Matan Azrad <matan@nvidia.com>, Ori Kam <orika@nvidia.com>,
Pallavi Kadam <pallavi.kadam@intel.com>,
Reshma Pattan <reshma.pattan@intel.com>,
Sameh Gobriel <sameh.gobriel@intel.com>,
Suanming Mou <suanmingm@nvidia.com>, Thomas Monjalon <thomas@monjalon.net>,
Tyler Retzlaff <roretzla@linux.microsoft.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
Volodymyr Fialko <vfialko@marvell.com>,
Yipeng Wang <yipeng1.wang@intel.com>, Yuying Zhang <Yuying.Zhang@intel.com>
Subject: [PATCH 03/16] ethdev: remove use of VLAs for Windows built code
Date: Wed, 17 Apr 2024 16:41:46 -0700
Message-Id: <1713397319-26135-4-git-send-email-roretzla@linux.microsoft.com>
X-Mailer: git-send-email 1.8.3.1
In-Reply-To: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com>
References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
lib/ethdev/rte_ethdev.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index f1c658f..cd2ed74 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -3241,7 +3241,8 @@ enum {
}
/* Get id-name lookup table */
- struct rte_eth_xstat_name xstats_names[cnt_xstats];
+ struct rte_eth_xstat_name *xstats_names =
+ alloca(sizeof(struct rte_eth_xstat_name) * cnt_xstats);
if (cnt_xstats != rte_eth_xstats_get_names_by_id(
port_id, xstats_names, cnt_xstats, NULL)) {
@@ -3342,7 +3343,7 @@ enum {
return -EINVAL;
if (ids && dev->dev_ops->xstats_get_names_by_id != NULL && size > 0) {
- uint64_t ids_copy[size];
+ uint64_t *ids_copy = alloca(sizeof(uint64_t) * size);
for (i = 0; i < size; i++) {
if (ids[i] < basic_count) {
@@ -3535,7 +3536,7 @@ enum {
if (ret < 0)
return ret;
expected_entries = (uint16_t)ret;
- struct rte_eth_xstat xstats[expected_entries];
+ struct rte_eth_xstat *xstats = alloca(sizeof(struct rte_eth_xstat) * expected_entries);
basic_count = eth_dev_get_xstats_basic_count(dev);
/* Return max number of stats if no ids given */
@@ -3551,7 +3552,7 @@ enum {
if (ids && dev->dev_ops->xstats_get_by_id != NULL && size) {
unsigned int basic_count = eth_dev_get_xstats_basic_count(dev);
- uint64_t ids_copy[size];
+ uint64_t *ids_copy = alloca(sizeof(uint64_t) * size);
for (i = 0; i < size; i++) {
if (ids[i] < basic_count) {
--
1.8.3.1