From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Ravi Kerur <rkerur@gmail.com> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 5/6] Move common functions in eal_timer.c Date: Mon, 05 Jan 2015 22:09:23 +0100 Message-ID: <1714110.hG7iXKm2FP@xps13> (raw) In-Reply-To: <1419957440-11767-5-git-send-email-rkerur@gmail.com> 2014-12-30 11:37, Ravi Kerur: > Use common function name set_tsc_freq_from_sysctl for BSD and Linux. [...] > +/** > + * This function sets TSC frequency from sysctl > + * for BSD and from clock for Linux. > + * > + * This function is private to the EAL. > + */ > +int set_tsc_freq_from_sysctl(void); [...] > -static int > -set_tsc_freq_from_clock(void) > +int > +set_tsc_freq_from_sysctl(void) NACK It doesn't seem reasonnable to call a function set_tsc_freq_from_sysctl() if it doesn't use sysctl. -- Thomas
next prev parent reply other threads:[~2015-01-05 21:09 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-12-30 16:36 [dpdk-dev] [PATCH v3 0/6] Move EAL common functions Ravi Kerur 2014-12-30 16:37 ` [dpdk-dev] [PATCH v3 1/6] Move common functions in eal_debug.c Ravi Kerur 2014-12-30 16:37 ` [dpdk-dev] [PATCH v3 2/6] Move common functions in eal_thread.c Ravi Kerur 2014-12-30 16:37 ` [dpdk-dev] [PATCH v3 3/6] Move common functions in eal.c Ravi Kerur 2014-12-30 16:37 ` [dpdk-dev] [PATCH v3 4/6] Move common functions in eal_lcore.c Ravi Kerur 2014-12-30 16:37 ` [dpdk-dev] [PATCH v3 5/6] Move common functions in eal_timer.c Ravi Kerur 2015-01-05 21:09 ` Thomas Monjalon [this message] 2014-12-30 16:37 ` [dpdk-dev] [PATCH v3 6/6] Move common functions in eal_memory.c Ravi Kerur 2015-01-05 21:17 ` Thomas Monjalon 2015-01-06 17:32 ` Ravi Kerur 2014-12-30 21:03 ` [dpdk-dev] [PATCH v3 0/6] Move EAL common functions Neil Horman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1714110.hG7iXKm2FP@xps13 \ --to=thomas.monjalon@6wind.com \ --cc=dev@dpdk.org \ --cc=rkerur@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git