From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 170165921 for ; Mon, 5 Jan 2015 22:09:47 +0100 (CET) Received: by mail-wg0-f43.google.com with SMTP id k14so10536541wgh.16 for ; Mon, 05 Jan 2015 13:09:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=tZ4US5ClpeF7m5vxX7Wu4G1NMYJ+r6XUBhZ+ZJTLG20=; b=ZWnUtXZnIOEG52d6jGCyJqmyjksYBUWYgD8kO3dPfXRUolqi2vyigdXQAC82uENqGJ nlg9N0Y9Y8PymMOw10k8S5YzrqKuaqrdUSiBEUtfP13sq9RwwvjHUlkR4o5dgJszwcdw Xrtdo29OqLIRUwomUhM8JJuLVgcHRmPNd0tHKVjaJaVK2Ii9OsvHyVyR9AG07ZxghHlr PYOf1TrUVWVGR0OMOiEWW9850hZ2XGh8LxuwqncdCY1LYWJJioARm2UImrTyiA5VbijU pVqbhHDquqhIaQctnh8nJd3mjp+Bam2jHeXqHEP4L7pIEwJP2l3yvTwBHJmdPjB3fhRv qkOg== X-Gm-Message-State: ALoCoQniRZQ03PehWMMZKQJScaBSV/0vnAbm4vJX2TUE6G3QeIPwQWJhc/YZukW/YzD1Dh7BPV0m X-Received: by 10.180.207.211 with SMTP id ly19mr29792662wic.73.1420492186685; Mon, 05 Jan 2015 13:09:46 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id gl11sm76829767wjc.40.2015.01.05.13.09.45 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Jan 2015 13:09:46 -0800 (PST) From: Thomas Monjalon To: Ravi Kerur Date: Mon, 05 Jan 2015 22:09:23 +0100 Message-ID: <1714110.hG7iXKm2FP@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.6-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1419957440-11767-5-git-send-email-rkerur@gmail.com> References: <1419957384-11693-1-git-send-email-rkerur@gmail.com> <1419957440-11767-1-git-send-email-rkerur@gmail.com> <1419957440-11767-5-git-send-email-rkerur@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 5/6] Move common functions in eal_timer.c X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jan 2015 21:09:47 -0000 2014-12-30 11:37, Ravi Kerur: > Use common function name set_tsc_freq_from_sysctl for BSD and Linux. [...] > +/** > + * This function sets TSC frequency from sysctl > + * for BSD and from clock for Linux. > + * > + * This function is private to the EAL. > + */ > +int set_tsc_freq_from_sysctl(void); [...] > -static int > -set_tsc_freq_from_clock(void) > +int > +set_tsc_freq_from_sysctl(void) NACK It doesn't seem reasonnable to call a function set_tsc_freq_from_sysctl() if it doesn't use sysctl. -- Thomas