* [dpdk-dev] [PATCH v2] fm10k: add missing newline to debug log
@ 2015-07-16 21:06 Stephen Hemminger
2015-07-21 7:43 ` Chen, Jing D
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2015-07-16 21:06 UTC (permalink / raw)
To: Jing Chen; +Cc: dev
If FM10K_DEBUG_DRIVER is enabled, then the log messages about
function entry are missing newline causing extremely long lines.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/fm10k/base/fm10k_osdep.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/fm10k/base/fm10k_osdep.h b/drivers/net/fm10k/base/fm10k_osdep.h
index 04f8fe9..53c433c 100644
--- a/drivers/net/fm10k/base/fm10k_osdep.h
+++ b/drivers/net/fm10k/base/fm10k_osdep.h
@@ -45,7 +45,7 @@ POSSIBILITY OF SUCH DAMAGE.
#define ERROR_REPORT2(v1, v2, v3) do { } while (0)
#define STATIC static
-#define DEBUGFUNC(F) DEBUGOUT(F);
+#define DEBUGFUNC(F) DEBUGOUT(F "\n");
#define DEBUGOUT(S, args...) PMD_DRV_LOG_RAW(DEBUG, S, ##args)
#define DEBUGOUT1(S, args...) DEBUGOUT(S, ##args)
#define DEBUGOUT2(S, args...) DEBUGOUT(S, ##args)
--
2.1.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH v2] fm10k: add missing newline to debug log
2015-07-16 21:06 [dpdk-dev] [PATCH v2] fm10k: add missing newline to debug log Stephen Hemminger
@ 2015-07-21 7:43 ` Chen, Jing D
2015-07-22 10:43 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Chen, Jing D @ 2015-07-21 7:43 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev
> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Friday, July 17, 2015 5:07 AM
> To: Chen, Jing D
> Cc: dev@dpdk.org; Stephen Hemminger
> Subject: [PATCH v2] fm10k: add missing newline to debug log
>
> If FM10K_DEBUG_DRIVER is enabled, then the log messages about
> function entry are missing newline causing extremely long lines.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by : Jing Chen <jing.d.chen@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH v2] fm10k: add missing newline to debug log
2015-07-21 7:43 ` Chen, Jing D
@ 2015-07-22 10:43 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2015-07-22 10:43 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev
> > If FM10K_DEBUG_DRIVER is enabled, then the log messages about
> > function entry are missing newline causing extremely long lines.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> Acked-by : Jing Chen <jing.d.chen@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-22 10:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-16 21:06 [dpdk-dev] [PATCH v2] fm10k: add missing newline to debug log Stephen Hemminger
2015-07-21 7:43 ` Chen, Jing D
2015-07-22 10:43 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).