From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id 3B5DFC3D6 for ; Sun, 2 Aug 2015 23:56:26 +0200 (CEST) Received: by wibxm9 with SMTP id xm9so91318709wib.1 for ; Sun, 02 Aug 2015 14:56:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=5eVs5tXQMv5xCd2+dyhh1kdEwv8NF3+N3ZTBK/mplwE=; b=DqvtuZJnHsOu+sNQmYsyPmrPUdefDo/0NUVXCUybAagXGEZ/oaUwOunvvKRg0VPoxf CeTO2gxx2BEXaXmohGI4uUutzwybQBzJmQsf281OnDbm/LhxAC5VXsgpojKlR23s8T09 XxwCpZ+drOpYw9CBXv1POsjmT381ud22YH6gW/51kH4j0GwL7WcZfoCRB9fpBEms5Jh5 aYjnkEhG1xIevahtLHZaulKbnMzPpJP1UHfS6xRxjf/j+CfoWkYfC+GMjQhkGiBi446G P6yXAwu33YFeoPEy38iKk07/PJ89wyje/ZMHOSKtprOqIr69J51ZDV4oQG2Za6gQf73t WPBw== X-Gm-Message-State: ALoCoQlXFt4OJLHMhhTvUfioxcL5cygPduE0lUEUmGXEf+iq6r04zY8XLYTK7Div6aTofV5CgNal X-Received: by 10.195.13.1 with SMTP id eu1mr27601741wjd.131.1438552586092; Sun, 02 Aug 2015 14:56:26 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id r6sm10163961wiy.13.2015.08.02.14.56.24 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 02 Aug 2015 14:56:24 -0700 (PDT) From: Thomas Monjalon To: Wenzhuo Lu Date: Sun, 02 Aug 2015 23:55:10 +0200 Message-ID: <1715977.YirRIvxXYr@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1438223940-12582-1-git-send-email-wenzhuo.lu@intel.com> References: <1438223940-12582-1-git-send-email-wenzhuo.lu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] e1000: fix the issue of wrongly reporting descriptor done X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Aug 2015 21:56:26 -0000 2015-07-30 10:39, Wenzhuo Lu: > Header buffer address for header split will be filled with the physical > address for DMA, which is actually not needed at all, as header split > hasn't been supported. Hardware requires the least bit of header address > which is 'Descriptor Done' bit when write back should be set to 0 by driver. > The issue is that if the user wants to reserve an odd number of bytes between > the mbuf header and data buffer, the physical address to be filled in the > descriptor would happen to be odd. That means the DD bit would be set to > non-zero by driver. That will result in reporting descriptor done wrongly. > > Signed-off-by: Wenzhuo Lu Applied, thanks