From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id C51142E89 for ; Thu, 6 Nov 2014 09:34:08 +0100 (CET) Received: by mail-wg0-f42.google.com with SMTP id k14so592324wgh.29 for ; Thu, 06 Nov 2014 00:43:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=hLz4eqI1iBRMZ6W/q1WKFDTopSmwwQKwGqWGCT5gcMg=; b=PNuHv77PockC4dn9Bdvc0D8FDxfak/TennhCYKy9MUNAtHvuj05EGqAyxVX3FU1mIb Fdxr+ia8VrXsGlWdjAE3tuvYtRx28VVM05zt7bpdWEjXideHOYHIvE5Sn3lcU1lw1CuE 1y8cIhaGqLOOoB6UoD6Q2kGjcDFqjZ0f5CfcYVYhhjsdyU461sPq9kXTk+tQOSZ1HQPp byw0fFD5b/hPHcfPdwQhbj21Td1vfLiRofakWFd1ecCH66nmvDZfd531Fg/fbcbUqr2m hWEmsYDL6lIVHSe4sObtDZ6nPUyBjwQEhylFwnolBFNe/x2p1So1fE2uPJa0PcwzBav7 SFzA== X-Gm-Message-State: ALoCoQn2383bNBpvhX61M1ZByb8+ZwjzvWq0dqpkqyJGI+PjZPz8hyyo+q2tqOcFeh5mQ9HBUsc1 X-Received: by 10.194.2.244 with SMTP id 20mr3610407wjx.4.1415263415428; Thu, 06 Nov 2014 00:43:35 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id rx8sm6921797wjb.30.2014.11.06.00.43.34 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Nov 2014 00:43:34 -0800 (PST) From: Thomas Monjalon To: "Zhang, Helin" Date: Thu, 06 Nov 2014 09:43:16 +0100 Message-ID: <1716176.vfqLo0fjgC@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: References: <1413180766-12211-1-git-send-email-helin.zhang@intel.com> <1845096.HFlylc4sxo@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 2/5] ethdev: add enum type and relevant structures for hash filter control X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Nov 2014 08:34:08 -0000 2014-11-06 03:41, Zhang, Helin: > > > +/** > > > + * A structure used to set or get filter swap information, to support > > > + * 'RTE_ETH_FILTER_HASH', 'RTE_ETH_FILTER_GET/RTE_ETH_FILTER_SET', > > > + * with information type 'RTE_ETH_HASH_FILTER_INFO_TYPE_FILTER_SWAP'. > > > + */ > > > +struct rte_eth_filter_swap_info { > > > + /**< Packet classification type, defined in rte_ethdev.h */ > > > + uint8_t pctype; > > > + /**< Offset of the 1st field of the 1st couple to be swapped. */ > > > + uint8_t off0_src0; > > > + /**< Offset of the 2nd field of the 1st couple to be swapped. */ > > > + uint8_t off0_src1; > > > + /**< Field length of the first couple. */ > > > + uint8_t len0; > > > + /**< Offset of the 1st field of the 2nd couple to be swapped. */ > > > + uint8_t off1_src0; > > > + /**< Offset of the 2nd field of the 2nd couple to be swapped. */ > > > + uint8_t off1_src1; > > > + /**< Field length of the second couple. */ > > > + uint8_t len1; > > > +}; > > > > I guess it would be easier to understand if > > RTE_ETH_HASH_FILTER_INFO_TYPE_FILTER_SWAP was defined previously. > > It has already been defined before this structure definition. > I don't think I have understood your idea. Could you help to explain more? Thanks! By "defined", I mean "explained". What is the action of swap filter? You offer new features in API without explaining them. It's probably obvious for you but not for me. -- Thomas