From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Jain, Deepak K" <deepak.k.jain@intel.com>,
"Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>
Cc: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
dev@dpdk.org, "Trahe, Fiona" <fiona.trahe@intel.com>,
"Griffin, John" <john.griffin@intel.com>
Subject: Re: [dpdk-dev] [PATCH] qat: change optimization flag for Intel QuickAssist Technology
Date: Tue, 07 Jun 2016 16:56:52 +0200 [thread overview]
Message-ID: <1716498.tfoInuLrnx@xps13> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8973C95607B@IRSMSX108.ger.corp.intel.com>
2016-05-31 11:29, De Lara Guarch, Pablo:
> Hi Deepak/Arek,
>
> > Hi Thomas,
> >
> > This change was made to fix the compilation issues arising when optimization
> > flag was changed. Hence its related to same optimization flag patch.
> > Do you want us to separate the Makefile and .c file change?
>
> I think you need to explain the change in the .c file and separate it to another patch, if it is not related to the Makefile change (and if it is related, consider creating a patchset, maybe).
Yes, or at least, explain the change in the commit message.
Thanks
prev parent reply other threads:[~2016-06-07 14:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 9:24 Arek Kusztal
2016-05-10 9:56 ` Jain, Deepak K
2016-05-13 8:17 ` Thomas Monjalon
2016-05-13 8:24 ` Jain, Deepak K
2016-05-31 11:29 ` De Lara Guarch, Pablo
2016-06-07 14:56 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1716498.tfoInuLrnx@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=john.griffin@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).