From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 3A6D72931 for ; Fri, 30 Sep 2016 17:01:35 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id b4so52314307wmb.0 for ; Fri, 30 Sep 2016 08:01:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=XJGwxykI+heC1xzIeK7IVFvGceo7oRz1E5xH+ooPIT4=; b=qPnQatOfWDH1/f5O5KhDGt4LuYHLmTtDKtdX3keoljDnmjqbzx75YQHdGJyg6rfjCz f0MtXox0a3NGbnJ8tveqe7ZYgqUR/M5KVrB34UOzlgr8iiAsVsCQbANOEVV8QJMoWFcL ypje9L2i6rBk8cBQ600fsSrbJlnctnTeqAwsDtOFzzlSq+6sLy7CHnVo79CX7Oy4VLjF pxuJQD9f6IIwhuxSPktRgnFg/e5gml/gzvOuxBtbeKQNR8RVdzBTPMLRgckodM4lTg0l IXHlcMMPskpAhHcQ3hUpaq9zHwukI5GSjTjKRf2GC0sWJYpnk9HBMwEdvAmxporOQdDM jGNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=XJGwxykI+heC1xzIeK7IVFvGceo7oRz1E5xH+ooPIT4=; b=Mm/G0EntFcAKgwPHEhHV18oOuQi6sAG0R70Y+fiGzNLAhyGxLczx9GUWtOJ22dKctz Yc0CnUKI/fbsO3yYM/Vw6XNCz1bTXyV+LxI4sbZ33XoXXaZjTnXrVA8WnHYk4SexdQgz scM52slvr8FS4N1uIdniqz3fTYgaJT07XmfFob6uGPwcoxt2PJq12wSibNZKUrkXGUTx dgjAFJMq0wViqeHcn9oVTBFPR20r1N7qXyeIKfVLDlvts3gP3nFzQqyeEj3wd3vcebKF JTRnInMFzJf6xP3BxACbNrOrDmmpeM+L0oSbrF8wt1YrRNpXATihP7jHt9zRRAuKX207 vLtg== X-Gm-Message-State: AA6/9RlsGOqbNStYywcXmWfr+yQT3Dg5ovBrefgicnYhfUEUc5M6PFhf+Ep6C8OcC8HNvm+E X-Received: by 10.28.41.131 with SMTP id p125mr4525135wmp.15.1475247695036; Fri, 30 Sep 2016 08:01:35 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id bc5sm20044025wjb.37.2016.09.30.08.01.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Sep 2016 08:01:34 -0700 (PDT) From: Thomas Monjalon To: John Ousterhout Cc: dev@dpdk.org, david.marchand@6wind.com Date: Fri, 30 Sep 2016 17:01:33 +0200 Message-ID: <17179105.NJRITsrcxm@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160928204244.8288-1-ouster@cs.stanford.edu> References: <20160928204244.8288-1-ouster@cs.stanford.edu> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] log: respect rte_openlog_stream calls before rte_eal_init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Sep 2016 15:01:35 -0000 2016-09-28 13:42, John Ousterhout: > Before this patch, rte_eal_init invoked rte_openlog_stream, cancelling > any application-specific logger and making it it impossible for an > application to capture the initial log messages generated during > rte_eal_init. With this patch, applications can capture all of the > log messages. It deserves an explanation of what the patch does, i.e. the new logic. If think you just want to remove the log init from rte_eal_init and use the default stream when it is not initialized (NULL). You could also remove the early log stream since the default one could work from the early stage. Indeed the complex log history was removed: http://dpdk.org/commit/a3f34a98 Thanks for improving the usability.